Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force no bbr when starting local devnet #3892

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Sep 20, 2024

Overview

adds the --force-no-bbr flag when starting the local devnet so that it works.

@rach-id rach-id requested a review from a team as a code owner September 20, 2024 14:33
@rach-id rach-id requested review from staheri14 and ninabarbakadze and removed request for a team September 20, 2024 14:33
@rach-id rach-id self-assigned this Sep 20, 2024
Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Walkthrough

Walkthrough

The pull request introduces modifications to two scripts, start_core0.sh and start_node_and_create_validator.sh, by adding the --force-no-bbr command-line argument to the celestia-appd start command. This new argument enforces the non-use of BBR (Bottleneck Bandwidth and Round-trip propagation time) congestion control during the application startup process. The overall structure of the commands in both scripts remains unchanged aside from this addition.

Changes

File Change Summary
local_devnet/scripts/start_core0.sh Added the --force-no-bbr argument to the celestia-appd start command.
local_devnet/scripts/start_node_and_create_validator.sh Added the --force-no-bbr argument to the celestia-appd start command.

Possibly related PRs

  • fix: show bbr error message on celestia-appd start #3851: The changes in this PR enhance error reporting related to the BBR congestion control algorithm, which is directly relevant to the modifications made in the main PR that introduced the --force-no-bbr argument in the startup scripts.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rach-id rach-id added the testing items that are strictly related to adding or extending test coverage label Sep 20, 2024
@celestia-bot celestia-bot requested a review from a team September 20, 2024 14:42
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck!
I was able to test, and containers work properly with this new added flag (which otherwise wouldn't)!

@rach-id rach-id enabled auto-merge (squash) September 20, 2024 18:56
@celestia-bot celestia-bot requested review from a team and cmwaters and removed request for a team September 20, 2024 18:56
@rach-id rach-id merged commit 45518aa into main Sep 23, 2024
31 checks passed
@rach-id rach-id deleted the force-no-bbr-devnet branch September 23, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants