test!: removes e2e benchmark tests for blocks >8MB, uses main branch for others #3866

staheri14 · 2024-09-11T22:06:28Z

staheri14 · 2024-09-12T23:49:55Z

The benchmark tests TwoNodeBigBlock8MBLatency and TwoNodeBigBlock8MB, using the latest main branch for the validators and txsim (i.e., using the changes in this PR), passed with no issues.

…-for-benchmark-tests

coderabbitai · 2024-09-12T23:51:07Z

Walkthrough

The pull request modifies the end-to-end benchmark tests by removing several test cases focused on larger block sizes (32MB and 64MB) and refactoring the code to utilize a dynamic function for retrieving application versions. This streamlines the testing process by focusing on 8MB block sizes and enhancing code maintainability.

Changes

File	Change Summary
`test/e2e/benchmark/main.go`	Removed test cases: `"TwoNodeBigBlock32MB"`, `"TwoNodeBigBlock64MB"`, `"LargeNetworkBigBlock32MB"`, `"LargeNetworkBigBlock64MB"` from the `tests` slice.
`test/e2e/benchmark/throughput.go`	Refactored `bigBlockManifest` into `getBigBlockManifest()` function for dynamic version retrieval, modified benchmark functions to use this new function, and removed functions for 32MB and 64MB benchmarks.

Assessment against linked issues

Objective	Addressed	Explanation
The e2e benchmark tests will be updated to use the latest from the `main` branch. (#[3865])	✅
Other benchmark tests for block sizes of 32 and 64MB will also be removed until a concrete plan is developed for those. (#[3865])	✅

Possibly related PRs

test(e2e benchmark): introduces test manifest and its related utilities #3391: Introduces a test manifest that enhances the E2EThroughput benchmarking tests, which may relate to the modifications in the main PR.
test(e2e benchmark): refactors E2EThroughput #3395: Refactors the E2EThroughput component, indicating a connection in the testing framework with changes made in the main PR.
fix: increases txsim grpc client max receive message size #3541: Updates to test parameters that may overlap with the test cases removed in the main PR.
feat: enables selection and execution of specific e2e benchmark tests #3595: Introduces functionality for selecting specific tests, relevant to the changes in the main PR involving the removal of certain test cases.
test: adding big block tests to the main branch #3612: Adds big block tests and modifies the throughput.go file, directly related to changes made in the main PR regarding test case management.
chore: improves code readability of e2e benchmark tests #3670: Improves code readability in benchmark tests, which may relate to the overall structure and organization of tests in the main PR.
test: improves e2e tests performance by reading the block metadata instead of the entire block data #3672: Enhances performance by changing how blockchain data is read, potentially relevant to the testing scenarios impacted by the changes in the main PR.

Suggested labels

chore, testing, WS: Big Blonks 🔭

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 95b7ebd and 102cc65.

Files selected for processing (1)

test/e2e/benchmark/throughput.go (2 hunks)

Files skipped from review as they are similar to previous changes (1)

test/e2e/benchmark/throughput.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…-for-benchmark-tests

rootulp · 2024-09-20T14:30:32Z

test/e2e/benchmark/throughput.go

+		MemoryRequest: resource.MustParse("12Gi"),
+		MemoryLimit:   resource.MustParse("12Gi"),
+		CPU:           resource.MustParse("8"),
+		Volume:        resource.MustParse("20Gi"),
+	    },
+	    TxClientsResource: testnet.Resources{
+		MemoryRequest: resource.MustParse("1Gi"),
+		MemoryLimit:   resource.MustParse("3Gi"),
+		CPU:           resource.MustParse("2"),
+		Volume:        resource.MustParse("1Gi"),
+        },


the indentation looks off and golangci-lint is complaining: https://github.com/celestiaorg/celestia-app/actions/runs/10950431497/job/30405641643?pr=3866#step:5:32

once you fix lint I'll reapprove @staheri14

rootulp · 2024-10-14T17:38:36Z

test/e2e/benchmark/throughput.go

 	manifest.Validators = 50
 	manifest.TxClients = 50
 	manifest.BlobSequences = 2
 	return runBenchmarkTest(logger, "LargeNetworkBigBlock8MB", manifest)
 }
-
-func LargeNetworkBigBlock32MB(logger *log.Logger) error {


I don't think this was part of the exported Go API https://pkg.go.dev/github.com/celestiaorg/celestia-app/[email protected]/test/e2e/benchmark so we can probably drop the ! from the PR title

evan-forbes

i'm good with removing these

in theory, we'll get a pulumi backend for knuu, which would allow us to use these, but we can add them back then

staheri14 added 3 commits September 11, 2024 14:09

uses the latest version of the main for benchmark tests

1cd5c35

refactors benchmark tests

e6598ee

removes deleted tests from available tests

b9a138d

staheri14 self-assigned this Sep 11, 2024

Merge remote-tracking branch 'origin/main' into sanaz/use-latest-main…

95b7ebd

…-for-benchmark-tests

staheri14 marked this pull request as ready for review September 12, 2024 23:50

staheri14 requested a review from a team as a code owner September 12, 2024 23:50

staheri14 requested review from rootulp and ninabarbakadze and removed request for a team September 12, 2024 23:50

staheri14 changed the title ~~test!: removes e2e benchmarks for blocks >8MB, uses main branch for others~~ test!: removes e2e benchmark tests for blocks >8MB, uses main branch for others Sep 13, 2024

rootulp previously approved these changes Sep 13, 2024

View reviewed changes

staheri14 enabled auto-merge (squash) September 13, 2024 16:42

staheri14 requested review from evan-forbes and rach-id September 13, 2024 19:39

ninabarbakadze previously approved these changes Sep 18, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into sanaz/use-latest-main…

102cc65

…-for-benchmark-tests

staheri14 dismissed stale reviews from ninabarbakadze and rootulp via 102cc65 September 19, 2024 23:27

celestia-bot requested a review from a team September 19, 2024 23:27

rootulp reviewed Sep 20, 2024

View reviewed changes

rootulp reviewed Oct 14, 2024

View reviewed changes

evan-forbes reviewed Oct 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test!: removes e2e benchmark tests for blocks >8MB, uses main branch for others #3866

test!: removes e2e benchmark tests for blocks >8MB, uses main branch for others #3866

staheri14 commented Sep 11, 2024

staheri14 commented Sep 12, 2024

coderabbitai bot commented Sep 12, 2024 •

edited

Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

rootulp Sep 20, 2024

ninabarbakadze Oct 14, 2024

rootulp Oct 14, 2024

evan-forbes left a comment

test!: removes e2e benchmark tests for blocks >8MB, uses main branch for others #3866

Are you sure you want to change the base?

test!: removes e2e benchmark tests for blocks >8MB, uses main branch for others #3866

Conversation

staheri14 commented Sep 11, 2024

staheri14 commented Sep 12, 2024

coderabbitai bot commented Sep 12, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

rootulp Sep 20, 2024

Choose a reason for hiding this comment

ninabarbakadze Oct 14, 2024

Choose a reason for hiding this comment

rootulp Oct 14, 2024

Choose a reason for hiding this comment

evan-forbes left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Sep 12, 2024 •

edited

Loading