Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove empty spec pages #3863

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 11, 2024

Follow up to #3822. Not sure how I missed this but there were mostly empty files in the nested specs/ directory. I think a previous invocation of mdbook serve auto-generated them but they're not used.

@rootulp rootulp self-assigned this Sep 11, 2024
@rootulp rootulp requested review from liamsi and a team as code owners September 11, 2024 20:04
@rootulp rootulp requested review from rach-id and ninabarbakadze and removed request for a team September 11, 2024 20:04
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files selected but had no reviewable changes (22)
  • specs/src/specs/ante_handler.md
  • specs/src/specs/ante_handler_v1.md
  • specs/src/specs/ante_handler_v2.md
  • specs/src/specs/block_proposer.md
  • specs/src/specs/block_validity_rules.md
  • specs/src/specs/cat_pool.md
  • specs/src/specs/consensus.md
  • specs/src/specs/data_square_layout.md
  • specs/src/specs/data_structures.md
  • specs/src/specs/fraud_proofs.md
  • specs/src/specs/multisig.md
  • specs/src/specs/namespace.md
  • specs/src/specs/networking.md
  • specs/src/specs/parameters.md
  • specs/src/specs/parameters_v1.md
  • specs/src/specs/parameters_v2.md
  • specs/src/specs/public_key_cryptography.md
  • specs/src/specs/resource_pricing.md
  • specs/src/specs/shares.md
  • specs/src/specs/state_machine_modules.md
  • specs/src/specs/state_machine_modules_v1.md
  • specs/src/specs/state_machine_modules_v2.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp requested review from cmwaters and evan-forbes and removed request for liamsi September 11, 2024 20:05
@celestia-bot celestia-bot requested a review from a team September 11, 2024 20:05
@rootulp rootulp merged commit b4e12ca into celestiaorg:main Sep 12, 2024
33 of 34 checks passed
@rootulp rootulp deleted the rp/remove-empty-pages branch September 12, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants