chore: add test/util/genesis on v1.x #3520

ninabarbakadze · 2024-05-31T18:00:44Z

Overview

adding genesis to utils as part of #2414

coderabbitai · 2024-05-31T18:00:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

rach-id

As a first pass, why is this needed to be in v1.x?

ninabarbakadze · 2024-06-04T12:26:57Z

As a first pass, why is this needed to be in v1.x?

non determinism unit test. testApp needs to be constructed the same way so i wanted to reuse this logic. the context is here in the pr description #3513

rootulp

LGTM. One question about whether tests were moved or deleted.

test/util/testnode/config.go

app/test/integration_test.go

cmwaters

There's a lot of go API breaking changes in this PR. If you want to add the genesis package, it needs to be a purely additive change without removing several files and functions.

rach-id

utAck

rach-id · 2024-06-05T08:31:08Z

There's a lot of go API breaking changes in this PR

Should we worry about breaking changes to the testing infrastructure in release branches?

cmwaters · 2024-06-06T08:38:20Z

Should we worry about breaking changes to the testing infrastructure in release branches?

cmwaters · 2024-06-06T08:39:45Z

Should we worry about breaking changes to the testing infrastructure in release branches?

Yes (I personally have repos that use the testing infrastructure code). If we don't want people using it, we should not make it public

rootulp · 2024-06-06T13:56:39Z

I revise my review b/c the testing infra is exported so this is technically API breaking like Callum mentioned.

@ninabarbakadze is it possible to add new exported functions and deprecate existing functions to avoid all API breaks?

ninabarbakadze · 2024-06-06T14:03:30Z

I revise my review b/c the testing infra is exported so this is technically API breaking like Callum mentioned.

@ninabarbakadze is it possible to add new exported functions and deprecate existing functions to avoid all API breaks?

Yes, I'm going to manually add the genesis folder without cherry picking evan's commit and see if it'll make the process of maintaining the API easier.

## Overview Fixes #2414 ### This test is split up in a few parts: - Execute transactions deterministically on v1 and save the AppHash. #3522 ([includes genesis folder backport from utils](#3520)) - Set up the same testApp environment on main, execute transactions and assert that the AppHash matches the one from v1 ### Verifying the AppHash: If you want to make sure that the expected AppHash is correct, you can run the [non determinism test on v1.x](#3522) that generates it. ### Follow-ups: #3509 #3540 --------- Co-authored-by: Rootul P <[email protected]>

## Overview Fixes #2414 ### This test is split up in a few parts: - Execute transactions deterministically on v1 and save the AppHash. celestiaorg/celestia-app#3522 ([includes genesis folder backport from utils](celestiaorg/celestia-app#3520)) - Set up the same testApp environment on main, execute transactions and assert that the AppHash matches the one from v1 ### Verifying the AppHash: If you want to make sure that the expected AppHash is correct, you can run the [non determinism test on v1.x](celestiaorg/celestia-app#3522) that generates it. ### Follow-ups: #3509 celestiaorg/celestia-app#3540 --------- Co-authored-by: Rootul P <[email protected]>

ninabarbakadze force-pushed the nina/backport-multi-validator-genesis branch from f0b624e to f1599fd Compare June 1, 2024 08:06

ninabarbakadze mentioned this pull request Jun 3, 2024

test: consistent appHash between commits #3513

Merged

ninabarbakadze requested review from cmwaters and rootulp June 4, 2024 10:56

ninabarbakadze marked this pull request as ready for review June 4, 2024 10:56

ninabarbakadze requested review from rach-id, evan-forbes and a team as code owners June 4, 2024 10:56

rach-id reviewed Jun 4, 2024

View reviewed changes

rootulp assigned ninabarbakadze Jun 4, 2024

rootulp previously approved these changes Jun 4, 2024

View reviewed changes

test/util/testnode/config.go Outdated Show resolved Hide resolved

app/test/integration_test.go Outdated Show resolved Hide resolved

app/test/integration_test.go Outdated Show resolved Hide resolved

ninabarbakadze dismissed rootulp’s stale review via 7c25491 June 4, 2024 16:52

celestia-bot requested a review from a team June 4, 2024 16:53

rootulp previously approved these changes Jun 4, 2024

View reviewed changes

cmwaters requested changes Jun 5, 2024

View reviewed changes

rach-id previously approved these changes Jun 5, 2024

View reviewed changes

evan-forbes previously approved these changes Jun 5, 2024

View reviewed changes

rootulp self-requested a review June 6, 2024 13:54

ninabarbakadze marked this pull request as draft June 6, 2024 14:04

chore: revert backport and manually add genesis

af9ecdf

ninabarbakadze dismissed stale reviews from evan-forbes, rach-id, and rootulp via af9ecdf June 7, 2024 15:14

ninabarbakadze force-pushed the nina/backport-multi-validator-genesis branch from 7c25491 to af9ecdf Compare June 7, 2024 15:14

ninabarbakadze changed the title ~~chore: multi validator genesis backport~~ chore: add test/util/genesis on v1.x Jun 7, 2024

ninabarbakadze marked this pull request as ready for review June 7, 2024 16:14

ninabarbakadze requested review from cmwaters, evan-forbes and rach-id June 7, 2024 16:14

rootulp approved these changes Jun 7, 2024

View reviewed changes

cmwaters approved these changes Jun 10, 2024

View reviewed changes

ninabarbakadze merged commit 9c6322c into v1.x Jun 10, 2024
24 of 25 checks passed

ninabarbakadze deleted the nina/backport-multi-validator-genesis branch June 10, 2024 12:04

rach-id mentioned this pull request Jun 20, 2024

chore!: deletes JSONRPCError from e2e test_helpers #3602

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add test/util/genesis on v1.x #3520

chore: add test/util/genesis on v1.x #3520

ninabarbakadze commented May 31, 2024 •

edited

Loading

coderabbitai bot commented May 31, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

rach-id left a comment

ninabarbakadze commented Jun 4, 2024 •

edited

Loading

rootulp left a comment

cmwaters left a comment

rach-id left a comment

rach-id commented Jun 5, 2024

cmwaters commented Jun 6, 2024

cmwaters commented Jun 6, 2024

rootulp commented Jun 6, 2024

ninabarbakadze commented Jun 6, 2024

chore: add test/util/genesis on v1.x #3520

chore: add test/util/genesis on v1.x #3520

Conversation

ninabarbakadze commented May 31, 2024 • edited Loading

Overview

coderabbitai bot commented May 31, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

rach-id left a comment

Choose a reason for hiding this comment

ninabarbakadze commented Jun 4, 2024 • edited Loading

rootulp left a comment

Choose a reason for hiding this comment

cmwaters left a comment

Choose a reason for hiding this comment

rach-id left a comment

Choose a reason for hiding this comment

rach-id commented Jun 5, 2024

cmwaters commented Jun 6, 2024

cmwaters commented Jun 6, 2024

rootulp commented Jun 6, 2024

ninabarbakadze commented Jun 6, 2024

ninabarbakadze commented May 31, 2024 •

edited

Loading

coderabbitai bot commented May 31, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

ninabarbakadze commented Jun 4, 2024 •

edited

Loading