Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: backports knuu optimizations from 3493 #3515

Merged
merged 39 commits into from
Jun 19, 2024
Merged

test: backports knuu optimizations from 3493 #3515

Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
ecc18ea
adds tracing
staheri14 May 29, 2024
60de468
adds tracing config options
staheri14 May 29, 2024
c973daa
adds blobPerSequence param
staheri14 May 29, 2024
1c53b71
backports all the optimization in knuu
staheri14 May 29, 2024
93d5a4e
adds tracing config fields to the Manifest
staheri14 May 29, 2024
248687e
enables local tracing in E2EThroughput tests
staheri14 May 29, 2024
01b9203
updates config based the choice of local tracing
staheri14 May 29, 2024
92cec9f
refactors the code
staheri14 May 29, 2024
9507488
removes remoteHomeDirectory field and getter
staheri14 May 29, 2024
7b8ad0a
includes missing blobPerSequence
staheri14 May 29, 2024
685ee9d
allows specifying path to save the table when pulling round state table
staheri14 May 29, 2024
43fb5ac
checks if local tracing works
staheri14 May 29, 2024
7d628d5
defines pushing traced data in benchmark tests
staheri14 May 29, 2024
33fa9cd
downloads traces if specified so
staheri14 May 29, 2024
8831859
removes unused comments
staheri14 May 29, 2024
566e283
deletes MakeTracePushConfig as it is not used
staheri14 May 29, 2024
1772eb4
resolves linter issues
staheri14 May 29, 2024
c64c811
Merge branch 'sanaz/add-tracing-configs' into sanaz/backport-optimiza…
staheri14 May 29, 2024
1515dea
updates knuu version to v0.13.3
staheri14 May 29, 2024
2df5bf3
addresses first round of comments
staheri14 May 30, 2024
fb66838
Merge branch 'sanaz/add-tracing-configs' into sanaz/backport-optimiza…
staheri14 May 30, 2024
3b6fbd0
Merge remote-tracking branch 'origin/main' into sanaz/add-tracing-con…
staheri14 Jun 3, 2024
102272e
fixes linter complaint
staheri14 Jun 3, 2024
7185d2d
Merge branch 'sanaz/add-tracing-configs' into sanaz/backport-optimiza…
staheri14 Jun 3, 2024
9f19d68
Merge branch 'main' into sanaz/backport-optimization-knuu
staheri14 Jun 4, 2024
df9107f
removes commented codes
staheri14 Jun 4, 2024
f7a0f81
update go mod
staheri14 Jun 4, 2024
c8fc94d
removes node_helpers
staheri14 Jun 4, 2024
77a5b4f
gofumpt node.go
staheri14 Jun 4, 2024
6f25001
Merge remote-tracking branch 'origin/main' into sanaz/backport-optimi…
staheri14 Jun 18, 2024
bb65e2b
renames GlobalMin to NetworkMin
staheri14 Jun 18, 2024
6aab4b4
fixes another instance
staheri14 Jun 18, 2024
c62383b
Merge branch 'sanaz/replace-GlobalMinGasPrice-w-NetworkMinGasPrice' i…
staheri14 Jun 18, 2024
fee3c03
removes unused functions from test_helpers
staheri14 Jun 18, 2024
8fc2775
deletes parts in the benchmark test that attempts rerunning txsims
staheri14 Jun 18, 2024
102406e
Merge branch 'main' into sanaz/backport-optimization-knuu
staheri14 Jun 18, 2024
ed3c96c
Merge branch 'sanaz/fix-txsim-failure' into sanaz/backport-optimizati…
staheri14 Jun 18, 2024
5d72549
Merge branch 'main' into sanaz/backport-optimization-knuu
evan-forbes Jun 19, 2024
817816c
Merge branch 'main' into sanaz/backport-optimization-knuu
staheri14 Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 24 additions & 25 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
github.com/celestiaorg/blobstream-contracts/v3 v3.1.0
github.com/celestiaorg/go-square v1.1.0
github.com/celestiaorg/go-square/merkle v0.0.0-20240117232118-fd78256df076
github.com/celestiaorg/knuu v0.13.2
github.com/celestiaorg/knuu v0.13.3
github.com/celestiaorg/nmt v0.21.0
github.com/celestiaorg/rsmt2d v0.13.1
github.com/cosmos/cosmos-proto v1.0.0-beta.5
Expand All @@ -29,7 +29,7 @@ require (
github.com/stretchr/testify v1.9.0
github.com/tendermint/tendermint v0.34.29
github.com/tendermint/tm-db v0.6.7
golang.org/x/exp v0.0.0-20231206192017-f3f8817b8deb
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuu Out of curiosity, why this change is needed? I backported it from the other PR https://github.com/celestiaorg/celestia-app/pull/3493/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R32

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don't know. It was not done on purpose.

golang.org/x/exp v0.0.0-20240213143201-ec583247a57a
google.golang.org/genproto/googleapis/api v0.0.0-20240318140521-94a12d6c2237
google.golang.org/grpc v1.64.0
google.golang.org/protobuf v1.34.1
Expand All @@ -56,7 +56,7 @@ require (
github.com/bgentry/speakeasy v0.1.0 // indirect
github.com/bits-and-blooms/bitset v1.10.0 // indirect
github.com/btcsuite/btcd/btcec/v2 v2.3.2 // indirect
github.com/celestiaorg/bittwister v0.0.0-20231211182706-b065de784c03 // indirect
github.com/celestiaorg/bittwister v0.0.0-20231213180407-65cdbaf5b8c7 // indirect
github.com/celestiaorg/merkletree v0.0.0-20210714075610-a84dc3ddbbe4 // indirect
github.com/cenkalti/backoff/v4 v4.1.3 // indirect
github.com/cespare/xxhash v1.1.0 // indirect
Expand Down Expand Up @@ -85,8 +85,8 @@ require (
github.com/dgraph-io/ristretto v0.1.1 // indirect
github.com/dgryski/go-farm v0.0.0-20200201041132-a6ae2369ad13 // indirect
github.com/distribution/reference v0.5.0 // indirect
github.com/docker/docker v26.0.2+incompatible // indirect
github.com/docker/go-connections v0.4.0 // indirect
github.com/docker/docker v26.1.2+incompatible // indirect
github.com/docker/go-connections v0.4.1-0.20210727194412-58542c764a11 // indirect
github.com/docker/go-units v0.5.0 // indirect
github.com/dustin/go-humanize v1.0.1 // indirect
github.com/dvsekhvalnov/jose2go v1.6.0 // indirect
Expand All @@ -104,6 +104,7 @@ require (
github.com/go-openapi/jsonreference v0.20.2 // indirect
github.com/go-openapi/swag v0.22.3 // indirect
github.com/go-playground/validator/v10 v10.11.2 // indirect
github.com/goccy/go-json v0.10.2 // indirect
github.com/godbus/dbus v0.0.0-20190726142602-4481cbc300e2 // indirect
github.com/gogo/gateway v1.1.0 // indirect
github.com/golang/glog v1.2.0 // indirect
Expand Down Expand Up @@ -138,15 +139,16 @@ require (
github.com/hdevalence/ed25519consensus v0.0.0-20220222234857-c00d1f31bab3 // indirect
github.com/holiman/uint256 v1.2.4 // indirect
github.com/iancoleman/orderedmap v0.2.0 // indirect
github.com/imdario/mergo v0.3.13 // indirect
github.com/imdario/mergo v0.3.16 // indirect
github.com/improbable-eng/grpc-web v0.15.0 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/jmespath/go-jmespath v0.4.0 // indirect
github.com/jmhodges/levigo v1.0.0 // indirect
github.com/joho/godotenv v1.5.1 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/klauspost/compress v1.17.6 // indirect
github.com/klauspost/cpuid/v2 v2.2.6 // indirect
github.com/klauspost/cpuid/v2 v2.2.7 // indirect
github.com/klauspost/reedsolomon v1.12.1 // indirect
github.com/lib/pq v1.10.7 // indirect
github.com/libp2p/go-buffer-pool v0.1.0 // indirect
Expand All @@ -160,8 +162,7 @@ require (
github.com/mimoo/StrobeGo v0.0.0-20210601165009-122bf33a46e0 // indirect
github.com/minio/highwayhash v1.0.2 // indirect
github.com/minio/md5-simd v1.1.2 // indirect
github.com/minio/minio-go/v7 v7.0.69 // indirect
github.com/minio/sha256-simd v1.0.1 // indirect
github.com/minio/minio-go/v7 v7.0.70 // indirect
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/mitchellh/go-testing-interface v1.14.1 // indirect
github.com/mitchellh/mapstructure v1.5.0 // indirect
Expand All @@ -172,10 +173,9 @@ require (
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/mtibben/percent v0.2.1 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/mxk/go-flowrate v0.0.0-20140419014527-cca7078d478f // indirect
github.com/onsi/ginkgo v1.16.5 // indirect
github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/opencontainers/image-spec v1.1.0-rc2 // indirect
github.com/opencontainers/image-spec v1.1.0-rc2.0.20221005185240-3a7f492d3f1b // indirect
github.com/pelletier/go-toml/v2 v2.1.0 // indirect
github.com/petermattis/goid v0.0.0-20230317030725-371a4b8eda08 // indirect
github.com/pkg/errors v0.9.1 // indirect
Expand Down Expand Up @@ -212,38 +212,37 @@ require (
go.opencensus.io v0.24.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.49.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.49.0 // indirect
go.opentelemetry.io/otel v1.24.0 // indirect
go.opentelemetry.io/otel v1.26.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.24.0 // indirect
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.18.0 // indirect
go.opentelemetry.io/otel/metric v1.24.0 // indirect
go.opentelemetry.io/otel/sdk v1.24.0 // indirect
go.opentelemetry.io/otel/trace v1.24.0 // indirect
go.opentelemetry.io/otel/metric v1.26.0 // indirect
go.opentelemetry.io/otel/sdk v1.26.0 // indirect
go.opentelemetry.io/otel/trace v1.26.0 // indirect
go.opentelemetry.io/proto/otlp v1.1.0 // indirect
go.uber.org/atomic v1.11.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
go.uber.org/zap v1.24.0 // indirect
go.uber.org/zap v1.27.0 // indirect
golang.org/x/crypto v0.22.0 // indirect
golang.org/x/mod v0.17.0 // indirect
golang.org/x/net v0.24.0 // indirect
golang.org/x/oauth2 v0.18.0 // indirect
golang.org/x/sync v0.7.0 // indirect
golang.org/x/sys v0.19.0 // indirect
golang.org/x/sys v0.20.0 // indirect
golang.org/x/term v0.19.0 // indirect
golang.org/x/text v0.14.0 // indirect
golang.org/x/text v0.15.0 // indirect
golang.org/x/time v0.5.0 // indirect
golang.org/x/tools v0.20.0 // indirect
google.golang.org/api v0.169.0 // indirect
google.golang.org/appengine v1.6.8 // indirect
google.golang.org/genproto v0.0.0-20240227224415-6ceb2ff114de // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240401170217-c3f982113cda // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/ini.v1 v1.67.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
k8s.io/api v0.29.3 // indirect
k8s.io/apimachinery v0.29.3 // indirect
k8s.io/client-go v0.29.2 // indirect
k8s.io/klog/v2 v2.110.1 // indirect
k8s.io/kube-openapi v0.0.0-20231010175941-2dd684a91f00 // indirect
k8s.io/api v0.28.2 // indirect
k8s.io/apimachinery v0.28.2 // indirect
k8s.io/client-go v0.28.2 // indirect
k8s.io/klog/v2 v2.120.1 // indirect
k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340 // indirect
k8s.io/utils v0.0.0-20230726121419-3b25d923346b // indirect
nhooyr.io/websocket v1.8.6 // indirect
rsc.io/tmplfunc v0.0.3 // indirect
Expand Down
Loading
Loading