fix: MajorUpgradeToV2 e2e test

[ninabarbakadze]

Overview

fixes #3321

[ninabarbakadze]

the error was caused by me updating DefaultConsensusParams version to v2 while working on minfee module

[coderabbitai]

Warning

Rate Limit Exceeded

@ninabarbakadze has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 36 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 3304191 and 4b61f45.

Walkthrough

The changes entail updates to function parameters and method signatures, introducing new functionalities, and refactoring existing code to support versioning and upgrade logic. These modifications aim to enhance the application's ability to manage different versions and upgrades effectively, ensuring compatibility and robustness in network operations.

Changes

Files	Summary
test/e2e/.../throughput.go, test/e2e/.../simple.go	Additional parameter appconsts.LatestVersion in testnets.New calls.
test/e2e/.../check_upgrades.go	Added parameters and methods for version and consensus parameters handling.
test/e2e/main.go	Adjusted test activation for major upgrades.
test/e2e/testnets/testnet.go, test/util/genesis/genesis.go	Updated genesis block creation to include versioning.
app/.../*.go	Extensive refactoring and new imports to support app functionality and version management.
test/interchain/..., test/txsim/..., test/util/...	Various enhancements and new functionalities focusing on testing interchain operations and transaction simulations.
tools/blockscan/...	Introduced tools for block scanning and transaction analysis.

Assessment against linked issues

Objective	Addressed	Explanation
MajorUpgradeToV2 in e2e tests is failing due to version mismatch before the upgrade (#3321)	❌	The changes do not directly address the version mismatch issue as described in the linked issue. The PR enhancements focus on version management and testing capabilities but do not resolve the specific problem of version mismatches during upgrades. Further investigation and targeted fixes are needed to address the failing test scenario.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cmwaters]

I thought I fixed this problem beforehand. I guess this got lost when we refactored this to a binary.

I think you just need to add the line

testnet.SetConsensusParams(app.DefaultInitialConsensusParams())

in MajorUpgradeToV2 and it should work

[staheri14]

LGTM! though I'll defer it to Callum for final approval.

[coderabbitai]

Actionable comments posted: 0

Out of diff range and nitpick comments (2)

test/e2e/check_upgrades.go (2)

Line range hint 22-102: Consider refactoring MinorVersionCompatibility to improve readability and maintainability. Breaking down the function into smaller, more focused helper functions can make the code easier to understand and test.

---

145-145: The file should adhere to Go formatting standards. Consider running gofumpt to format the file according to Go's more stringent style guidelines.