-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Go 1.22 #3142
Conversation
I may skip |
WalkthroughWalkthroughThe recent updates primarily focus on upgrading the Go version from 1.21.6 to 1.22.0 across various configuration files, Dockerfiles, and the Makefile. Additionally, there's an update in the test suite to skip a flaky test and updates in dependencies, including the Go version in Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -70,6 +70,7 @@ func (s *IntegrationTestSuite) SetupSuite() { | |||
|
|||
func (s *IntegrationTestSuite) TestMaxBlockSize() { | |||
t := s.T() | |||
t.Skip() // skip this test because it is flaky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of t.Skip()
effectively skips the TestMaxBlockSize
test due to its flakiness. While this addresses the immediate issue of test unreliability, it's important to consider the long-term implications of disabling tests. Ideally, efforts should be made to identify and resolve the root cause of the flakiness to ensure comprehensive test coverage and system reliability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Do we have an issue for the flaky test already?
Yep: #3086 |
Closes celestiaorg#3102 Upgrade to Go 1.22 and bump celestia-core to https://github.com/celestiaorg/celestia-core/releases/tag/v1.35.0-tm-v0.34.29 Note: skips the `TestMaxBlockSize` test because it's super flaky
Closes #3102
Upgrade to Go 1.22 and bump celestia-core to https://github.com/celestiaorg/celestia-core/releases/tag/v1.35.0-tm-v0.34.29
Note: skips the
TestMaxBlockSize
test because it's super flaky