fix: TestMaxBlockSize flake #3089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test passes but the app version in test node differs from the one in the block height. ``` app version 0 block header 0 app version 0 block header 2 app version 0 block header 0 app version 0 block header 2 ```
rootulp
requested review from
evan-forbes,
cmwaters,
staheri14 and
ninabarbakadze
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
None of these CodeRabbit comments are helpful b/c |
cmwaters
approved these changes
Feb 9, 2024
|
So was app version returning 0 or 2? |
cmwaters
requested changes
Feb 9, 2024
| @@ -19,6 +19,6 @@ func (app *App) GovSquareSizeUpperBound(ctx sdk.Context) int { | |||
| } | |||
|
|
|||
| gmax := int(app.BlobKeeper.GovMaxSquareSize(ctx)) | |||
| hardMax := appconsts.SquareSizeUpperBound(app.AppVersion(ctx)) | |||
| hardMax := appconsts.SquareSizeUpperBound(ctx.BlockHeader().Version.App) | |||
There was a problem hiding this comment.
Actually I don't get how this fixes it? The above fix using appVersion should work.
AppVersion calls the consensus parameters which includes the correct app version (the one we should rely on) because we don't always have a header in the context to compare with
|
Closing this for now. We're hoping that the flake resolves after we bump to a celestia-core release with celestiaorg/celestia-core#1202 and another fix for versions (@cmwaters will create an issue for). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3086 by reverting #3075
Re-opens #3066