feat!: reject proposals with un-decodable txs for appVersion two and above

[rootulp]

Closes #2663

Note: specs don't need to be updated because they already state

celestia-app/specs/src/specs/block_validity_rules.md

Line 44 in dc8b7f5

All remaining transactions must be decodable and pass all [AnteHandler](./ante_handler.md) checks.

[coderabbitai]

Walkthrough

Walkthrough

The code update introduces a new block validity rule in the ProcessProposal function that changes the behavior concerning transaction decoding errors. The rule is version-specific: for appVersion 1, transactions with decoding errors are skipped without logging an error, while for later versions, such transactions cause the proposal to be rejected. The corresponding tests have been updated to reflect this logic, ensuring that only decodable transactions are accepted in versions after appVersion 1.

Changes

File(s)	Change Summary
app/process_proposal.go	Modified to handle transaction decoding errors based on app version
app/test/process_proposal_test.go	Updated test cases to include appVersion and new validity rule

Assessment against linked issues

Objective	Addressed	Explanation
Reject any tx that is not decodable in ProcessProposal (#2663)	✅
Add a new block validity rule that rejects undecodable tx for appVersion > 1 (#2663)	✅
Ensure backward compatibility by not rejecting undecodable tx for appVersion 1 (#2663)	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[staheri14]

LGTM! I'd suggest updating the PR title to feat!: reject proposals with un-decodable txs for app versions higher than one

[cmwaters]

LGTM

Perhaps in another PR you can modify all those tests to use v2 since that's the version we currently care about.