Properly convert datetime from backend. Fix: #323, Fix: #330 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Apr 7, 2020
| # Because of that if datetime is naive we should use it as source timezone | ||
| # celery.utils.time.maybe_make_aware - always convert naive datetime to UTC | ||
| # which may be wrong in Django sicase. | ||
| django_timezone = getattr(settings, 'TIME_ZONE', None) |
There was a problem hiding this comment.
this will need a proper test case
for more information, see https://pre-commit.ci
|
a test is failing with this change. it would be great if you can fix the test |
cclauss
reviewed
Dec 19, 2023
| @@ -4,6 +4,7 @@ | |||
| import math | |||
| from multiprocessing.util import Finalize | |||
|
|
|||
| import pytz | |||
There was a problem hiding this comment.
Django v5 drops support for pytz timezones.
|
Please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#330