Set up graph_query testing infrastructure for task graph #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95) ❓ No new benchmark data submitted. ❓ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| fmt::format_to(std::back_inserter(dot), "{}->{}[{}];", d.node, tsk.tid, dependency_style(d.kind, d.origin)); | ||
| } | ||
| for(const auto& tsk : recorder.get_graph_nodes()) { | ||
| const char* shape = tsk->type == task_type::epoch || tsk->type == task_type::horizon ? "ellipse" : "box style=rounded"; |
There was a problem hiding this comment.
variable shape of type const char * can be declared const
| template <int Dims, typename Handler, typename Functor> | ||
| void dispatch_get_access(test_utils::mock_buffer<Dims>& mb, Handler& handler, access_mode mode, Functor rmfn) { | ||
| template <typename Builder, int Dims, typename Functor> | ||
| auto dispatch_get_access(Builder&& builder, test_utils::mock_buffer<Dims>& mb, access_mode mode, Functor rmfn) { |
There was a problem hiding this comment.
forwarding reference parameter builder is never forwarded inside the function body
| } | ||
|
|
||
| [[maybe_unused]] const task_id tid_8 = | ||
| test_utils::add_host_task(tt.tm, on_master_node, [&](handler& cgh) { buf_b.get_access<access_mode::read_write>(cgh, fixed<1>({0, 128})); }); | ||
| const auto tid_8 = tctx.master_node_host_task().read_write(buf_b, fixed<1>({0, 128})).submit(); |
There was a problem hiding this comment.
Value stored to tid_8 during its initialization is never read
Pull Request Test Coverage Report for Build 12467490376Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the TDAG (mostly) in line with CDAG and IDAG. What's missing is a hierarchical structure for
task_record, but since unlike for commands and instructions, a call tosubmit()only creates a single task (except for horizons) it turns out we don't really need this functionality anyway.