Change split functions to work on box instead of chunk #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95) ❓ No new benchmark data submitted. ❓ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -8,7 +9,7 @@ | |||
|
|
|||
| namespace celerity::detail { | |||
|
|
|||
| std::vector<chunk<3>> split_1d(const chunk<3>& full_chunk, const range<3>& granularity, const size_t num_chunks); | |||
| std::vector<chunk<3>> split_2d(const chunk<3>& full_chunk, const range<3>& granularity, const size_t num_chunks); | |||
| std::vector<box<3>> split_1d(const box<3>& full_box, const range<3>& granularity, const size_t num_boxs); | |||
There was a problem hiding this comment.
function celerity::detail::split_1d has a definition with different parameter names
| std::vector<chunk<3>> split_1d(const chunk<3>& full_chunk, const range<3>& granularity, const size_t num_chunks); | ||
| std::vector<chunk<3>> split_2d(const chunk<3>& full_chunk, const range<3>& granularity, const size_t num_chunks); | ||
| std::vector<box<3>> split_1d(const box<3>& full_box, const range<3>& granularity, const size_t num_boxs); | ||
| std::vector<box<3>> split_2d(const box<3>& full_box, const range<3>& granularity, const size_t num_boxs); |
There was a problem hiding this comment.
function celerity::detail::split_2d has a definition with different parameter names
Pull Request Test Coverage Report for Build 12434960318Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chunkis a purely user-facing type (and of questionable usefulness at that), and since all of our internal tracking is built aroundbox, splitting should follow suit.