Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage Tracy colors in a centralized location #320

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Manage Tracy colors in a centralized location #320

merged 1 commit into from
Dec 18, 2024

Conversation

psalz
Copy link
Member

@psalz psalz commented Dec 17, 2024

To get a better understanding of what colors are in use, and where.

@github-actions GitHub Actions
Copy link

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12376485983

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.05%
Totals Coverage Status
Change from base Build 12376021830: 0.0%
Covered Lines: 7088
Relevant Lines: 7193
💛 - Coveralls

fknorr
fknorr reviewed Dec 17, 2024
View reviewed changes
include/tracy.h Outdated Show resolved Hide resolved
fknorr
fknorr approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@fknorr fknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can s/::tracy/tracy/g in tracy.h.

@psalz psalz merged commit 6a2b416 into master Dec 18, 2024
17 checks passed
@psalz psalz deleted the tracy-colors branch December 18, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fknorr fknorr fknorr approved these changes

@PeterTh PeterTh PeterTh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psalz @coveralls @PeterTh @fknorr