Re-define access_mode explicitly, remove access_modes.h header
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alias was a leftover from pre-USM backed Celerity. This also resolves the ambiguity between namespaces celerity::access and celerity::detail::access (now removed).
|
Check-perf-impact results: (32e33781a20e2a3976ece8f7dc81ae2b) ❓ No new benchmark data submitted. ❓ |
Pull Request Test Coverage Report for Build 12054400606Details
💛 - Coveralls |
GagaLP
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
celerity::access_mode = sycl::access_modealias was a leftover from pre-USM backed Celerity. Re-defining the enum explicitly allows us to simplify the include tree somewhat. This also updates tests that were previously using the SYCL type.This has one "breaking change" that I'm not sure if we need to communicate: Users can't just pass SYCL access modes anymore (was undocumented), and
access_mode::atomichas been removed (wasn't supported on accessors anyway, but could be enumerated).Removing
access_modes.h(which contained functionality that was in parts only used by tests) andstruct mode_traitsresolves the ambiguity between namespaces celerity::access and celerity::detail::access (now removed).