Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude src/testspy from coverage #314

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Exclude src/testspy from coverage #314

merged 2 commits into from
Dec 9, 2024

Conversation

fknorr
Copy link
Contributor

@fknorr fknorr commented Nov 27, 2024

Since #308, scheduler / runtime testspies are located in src, which was included in coverage reports. Since it's test code, it shouldn't be.

I've also removed one leftover branch from #283 I found in the coverage report.

@fknorr fknorr added this to the 0.7.0 milestone Nov 27, 2024
@fknorr fknorr self-assigned this Nov 27, 2024
Copy link

Check-perf-impact results: (32e33781a20e2a3976ece8f7dc81ae2b)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

@coveralls
Copy link

coveralls commented Nov 27, 2024

Pull Request Test Coverage Report for Build 12235061821

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 95.026%

Totals Coverage Status
Change from base Build 12158562061: 0.1%
Covered Lines: 7091
Relevant Lines: 7199

💛 - Coveralls

@fknorr fknorr marked this pull request as ready for review November 27, 2024 16:32
@fknorr fknorr requested review from psalz and PeterTh November 27, 2024 16:32
Copy link
Contributor

@GagaLP GagaLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fknorr fknorr force-pushed the fix-testspy-coverage branch from 372a0f7 to 8137a26 Compare December 9, 2024 09:06
Copy link

github-actions bot commented Dec 9, 2024

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

@fknorr fknorr force-pushed the fix-testspy-coverage branch from 8137a26 to 1ae5388 Compare December 9, 2024 11:52
@fknorr fknorr merged commit 482cdd7 into master Dec 9, 2024
17 checks passed
@fknorr fknorr deleted the fix-testspy-coverage branch December 9, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants