Update libenvpp version to 1.5, remove obsolete code #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterTh
force-pushed
the
libenvpp-update
branch
from
72b070f to
b60446e
Compare
|
Check-perf-impact results: (32e33781a20e2a3976ece8f7dc81ae2b) ❓ No new benchmark data submitted. ❓ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
PeterTh
force-pushed
the
libenvpp-update
branch
from
b60446e to
9ee07b3
Compare
Pull Request Test Coverage Report for Build 12047961487Details
💛 - Coveralls |
fknorr
approved these changes
Nov 26, 2024
psalz
approved these changes
Nov 26, 2024
psalz
reviewed
Nov 26, 2024
PeterTh
force-pushed
the
libenvpp-update
branch
from
9ee07b3 to
551d11e
Compare
psalz
reviewed
Nov 27, 2024
| @@ -141,7 +141,7 @@ macro(fetch_content_from_submodule DEPNAME RELPATH) | |||
| # - another depencency of celerity-runtime that it transitively shares a depencency with (SimSYCL -> libenvpp) | |||
| # The top-level CMake project must ensure that there are no conflicts between dependency versions in this case. | |||
| if(${DEPNAME}_FOUND) | |||
| message(STATUS "Using system ${DEPNAME} in ${${DEPNAME}_DIR}") | |||
| message(STATUS "Using existing ${DEPNAME} in ${${DEPNAME}_DIR}, please ensure that the version (${${DEPNAME}_VERSION}) is compatible") | |||
There was a problem hiding this comment.
I don't want to be overly pedantic, but IMO this change would better fit with the libenvpp bump!
There was a problem hiding this comment.
You're overly pedantic :P
And some minor C++20 updates/refactoring
PeterTh
force-pushed
the
libenvpp-update
branch
from
551d11e to
8a8315f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very satisfying.
The new release of libenvpp does basic option parsing for us.
Also removed 3 completely unused functions from utils, and simplified some of the rest thanks to our switch to C++20.
Drive-by:
in
tracy.hto document this unusual header ordering.