Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single instance for retrieving a buffer label #214

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add single instance for retrieving a buffer label #214

merged 1 commit into from
Oct 25, 2023

Conversation

GagaLP
Copy link
Contributor

@GagaLP GagaLP commented Sep 14, 2023

This pull request is based on #211.

It adds a uniform way to retrieve a buffer label without the need to check for an empty string.
Every buffer label is formatted like: B{buffer_id} "{buffer_name}" .

@github-actions
Copy link

Check-perf-impact results: (7a518c63eb0655471fea6a4902fc0af7)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

@GagaLP GagaLP changed the title Buffer label Add single instance for retrieving a buffer label Sep 14, 2023
PeterTh
PeterTh approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@PeterTh PeterTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-actions[bot]
github-actions bot reviewed Sep 14, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/accessor.h Outdated Show resolved Hide resolved
test/accessor_tests.cc Outdated Show resolved Hide resolved
test/accessor_tests.cc Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Check-perf-impact results: (5a19ced85f862a00d0114dd241122462)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

fknorr
fknorr approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@fknorr fknorr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I like DRY, I'm not a fan of having debug-printing features in the buffer manager. Since this will have to be re-visited anyway when the IDAG refactoring removes buffer_manager, I'm fine with merging this in the meantime.

@GagaLP GagaLP merged commit de1f900 into master Oct 25, 2023
28 checks passed
@GagaLP GagaLP deleted the buffer_label branch October 25, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@fknorr fknorr fknorr approved these changes

@PeterTh PeterTh PeterTh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GagaLP @PeterTh @fknorr