Add experimental split constraints API #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check-perf-impact results: (7a518c63eb0655471fea6a4902fc0af7) ❓ No new benchmark data submitted. ❓ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fknorr
reviewed
Sep 12, 2023
psalz
force-pushed
the
split-constraints
branch
from
7680a72 to
7ad0ff1
Compare
|
Check-perf-impact results: (5a19ced85f862a00d0114dd241122462) ❓ No new benchmark data submitted. ❓ |
psalz
force-pushed
the
split-constraints
branch
from
7ad0ff1 to
29433eb
Compare
psalz
force-pushed
the
split-constraints
branch
from
29433eb to
fdf0897
Compare
fknorr
approved these changes
Oct 9, 2023
This adds a new experimental::constrain_split() API that can be used to limit the ways in which a kernel can be split, similar to how ND-range kernels are constrained to be split along work group boundaries.
psalz
force-pushed
the
split-constraints
branch
from
fdf0897 to
e887460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
experimental::constrain_split()API that can be used to limit the ways in which a kernel can be split, similar to how ND-range kernels are constrained to be split along work group boundaries.The implementation is rather trivial, as it mostly reuses the already existing task geometry mechanism we have. The only addition of note is that if an ND-range kernel is additionally constrained, the effective constraint will be the last common multiple
LCM(wg-size, user-constraint)