Unify newline at end, and set insert_final_newline

.editorconfig

@@ -3,6 +3,7 @@ root = true
 
 [*]
 end_of_line = lf
+insert_final_newline = true
 
 [{CMakeLists.txt, *.cmake}]
 indent_style = space

include/affinity.h

@@ -12,4 +12,4 @@ namespace detail {
 	constexpr static uint64_t min_cores_needed = 5;
 
 } // namespace detail
-} // namespace celerity
+} // namespace celerity

include/backend/backend.h

@@ -54,4 +54,4 @@ void memcpy_strided_device(sycl::queue& queue, const void* source_base_ptr, void
 	});
 }
 
-} // namespace celerity::detail::backend
+} // namespace celerity::detail::backend

include/backend/operations.h

@@ -14,4 +14,4 @@ struct backend_operations {
 	}
 };
 
-} // namespace celerity::detail::backend_detail
+} // namespace celerity::detail::backend_detail

include/backend/traits.h

@@ -38,4 +38,4 @@ struct name<backend::type::cuda> {
 	static constexpr const char* value = "CUDA";
 };
 
-} // namespace celerity::detail::backend_detail
+} // namespace celerity::detail::backend_detail

include/cgf_diagnostics.h

@@ -110,4 +110,4 @@ class cgf_diagnostics {
 	}
 };
 
-} // namespace celerity::detail
+} // namespace celerity::detail

include/closure_hydrator.h

@@ -158,4 +158,4 @@ class closure_hydrator {
 	}
 };
 
-}; // namespace celerity::detail
+}; // namespace celerity::detail

include/debug.h

@@ -17,4 +17,4 @@ namespace debug {
 
 	inline void set_task_name(celerity::handler& cgh, const std::string& debug_name) { detail::set_task_name(cgh, debug_name); }
 } // namespace debug
-} // namespace celerity
+} // namespace celerity

include/distributed_graph_generator.h

@@ -155,4 +155,4 @@ template <>
 struct hash<celerity::detail::write_command_state> {
 	size_t operator()(const celerity::detail::write_command_state& wcs) const { return std::hash<size_t>{}(static_cast<celerity::detail::command_id>(wcs)); }
 };
-} // namespace std
+} // namespace std

include/item.h

@@ -485,4 +485,4 @@ T inclusive_scan_over_group(const group<Dims>& g, V x, BinaryOperation binary_op
 	return cl::sycl::inclusive_scan_over_group(detail::get_sycl_item(g).get_group(), x, binary_op, init);
 }
 
-} // namespace celerity
+} // namespace celerity

include/lifetime_extending_state.h

@@ -40,4 +40,4 @@ inline std::shared_ptr<lifetime_extending_state> get_lifetime_extending_state(co
 	return wrapper.get_lifetime_extending_state();
 }
 
-} // namespace celerity::detail
+} // namespace celerity::detail

include/log.h

@@ -90,4 +90,4 @@ struct fmt::formatter<celerity::detail::log_map<Es...>> {
 		});
 		return out;
 	}
-};
+};

include/side_effect.h

@@ -66,4 +66,4 @@ class side_effect<void, Order> {
 template <typename T>
 side_effect(const host_object<T>&, handler&) -> side_effect<T>;
 
-} // namespace celerity::experimental
+} // namespace celerity::experimental

include/task_manager.h

@@ -109,7 +109,7 @@ namespace detail {
 
 		/**
 		 * @brief Adds a new buffer for dependency tracking
-		 * @arg host_initialized Whether this buffer has been initialized using a host pointer (i.e., it contains useful data before any write-task)
+		 * @param host_initialized Whether this buffer has been initialized using a host pointer (i.e., it contains useful data before any write-task)
 		 */
 		void add_buffer(buffer_id bid, const int dims, const range<3>& range, bool host_initialized);
 

src/backend/cuda_backend.cc

@@ -61,4 +61,4 @@ void memcpy_strided_device_cuda(sycl::queue& queue, const void* source_base_ptr,
 	CELERITY_CUDA_CHECK(cudaStreamSynchronize, 0);
 }
 
-} // namespace celerity::detail::backend_detail
+} // namespace celerity::detail::backend_detail

src/backend/generic_backend.cc

@@ -51,4 +51,4 @@ void memcpy_strided_device_generic(sycl::queue& queue, const void* source_base_p
 	}
 }
 
-} // namespace celerity::detail::backend_detail
+} // namespace celerity::detail::backend_detail

src/distributed_graph_generator.cc

@@ -644,4 +644,4 @@ void distributed_graph_generator::prune_commands_before(const command_id epoch)
 	}
 }
 
-} // namespace celerity::detail
+} // namespace celerity::detail

src/grid.cc

@@ -436,4 +436,4 @@ template region<1> region_difference(const region<1>& lhs, const region<1>& rhs)
 template region<2> region_difference(const region<2>& lhs, const region<2>& rhs);
 template region<3> region_difference(const region<3>& lhs, const region<3>& rhs);
 
-} // namespace celerity::detail
+} // namespace celerity::detail

src/platform_specific/affinity.unix.cc

@@ -17,4 +17,4 @@ namespace detail {
 	}
 
 } // namespace detail
-} // namespace celerity
+} // namespace celerity

src/platform_specific/affinity.win.cc

@@ -19,4 +19,4 @@ namespace detail {
 	}
 
 } // namespace detail
-} // namespace celerity
+} // namespace celerity

src/user_bench.cc

@@ -46,4 +46,4 @@ namespace experimental {
 		} // namespace detail
 	}     // namespace bench
 } // namespace experimental
-} // namespace celerity
+} // namespace celerity

test/backend_tests.cc

@@ -165,4 +165,4 @@ TEMPLATE_TEST_CASE_SIG("memcpy_strided_device allows to copy between the same de
 
 	const auto host_buf = copy_to_host(get_a_queue(tgt, src), tgt.ptr, cp.target_range);
 	verify_copied_linear_ids(host_buf.data(), cp.source_range, cp.source_offset, cp.target_range, cp.target_offset, cp.copy_range);
-}
+}

test/buffer_manager_test_utils.h

@@ -195,4 +195,4 @@ namespace test_utils {
 	};
 
 } // namespace test_utils
-} // namespace celerity
+} // namespace celerity

test/debug_naming_tests.cc

@@ -70,4 +70,4 @@ TEST_CASE("device_compute tasks derive debug name from kernel name", "[task]") {
 	CHECK(utils::simplify_task_name(t1->get_debug_name()) == "MyFirstKernel");
 	CHECK(utils::simplify_task_name(t2->get_debug_name()) == "MySecondKernel");
 	CHECK(utils::simplify_task_name(t3->get_debug_name()) == "MyThirdKernel<...>");
-}
+}

test/distributed_graph_generator_test_utils.h

@@ -635,4 +635,4 @@ inline task_builder::step task_builder::step::reduce(BufferT& buf, const bool in
 	    [this, &buf, include_current_buffer_value](handler& cgh) { add_reduction(cgh, m_dctx.create_reduction(buf.get_id(), include_current_buffer_value)); });
 }
 
-} // namespace celerity::test_utils
+} // namespace celerity::test_utils

test/graph_compaction_tests.cc

@@ -294,4 +294,4 @@ TEST_CASE("reaching an epoch will prune all nodes of the preceding task graph",
 	        {reader_writer_tid, dependency_kind::true_dep, dependency_origin::dataflow},
 	        {late_writer_tid, dependency_kind::true_dep, dependency_origin::dataflow},
 	    });
-}
+}

test/graph_gen_granularity_tests.cc

@@ -134,4 +134,4 @@ TEST_CASE("buffer accesses with empty ranges do not generate pushes or data-flow
 
 	CHECK(dctx.query(command_type::await_push).count() == 1);
 	CHECK(dctx.query(command_type::await_push, node_id(1)).count() == 1);
-}
+}

test/graph_gen_transfer_tests.cc

@@ -239,4 +239,4 @@ TEST_CASE("distributed_graph_generator generates anti-dependencies with subrange
 		CHECK(dctx.query(node_id(0), tid_a).have_successors(await_push, dependency_kind::anti_dep));
 		CHECK_FALSE(dctx.query(node_id(0), tid_b).have_successors(await_push, dependency_kind::anti_dep));
 	}
-}
+}

test/integration/backend.cc

@@ -118,4 +118,4 @@ int main(int argc, char* argv[]) {
 	test_copy<3>(q);
 
 	return EXIT_SUCCESS;
-}
+}

test/range_tests.cc

@@ -220,4 +220,4 @@ TEST_CASE("for_each_item behaves as expected", "[host_utils]") {
 	}
 }
 
-} // namespace celerity::detail
+} // namespace celerity::detail

test/system/distr_tests.cc

@@ -437,4 +437,4 @@ namespace detail {
 	}
 
 } // namespace detail
-} // namespace celerity
+} // namespace celerity

test/task_graph_tests.cc

@@ -714,4 +714,4 @@ namespace detail {
 	}
 
 } // namespace detail
-} // namespace celerity
+} // namespace celerity

test/task_ring_buffer_tests.cc

@@ -56,4 +56,4 @@ TEST_CASE_METHOD(test_utils::runtime_fixture, "deadlock in task ring buffer due
 	task_manager_testspy::create_task_slot(runtime::get_instance().get_task_manager());
 }
 
-} // namespace celerity::detail
+} // namespace celerity::detail

test/test_utils.h

@@ -454,4 +454,4 @@ struct StringMaker<sycl::platform> {
 	}
 };
 
-} // namespace Catch
+} // namespace Catch

test/test_utils_tests.cc

@@ -207,4 +207,4 @@ TEST_CASE("most operations fail when called on an empty query", "[command_query]
 	CHECK_THROWS_WITH(query.for_each_node([](const auto&) {}), "Operation 'for_each_node' not allowed on empty query");
 	CHECK_THROWS_WITH(query.have_successors(command_query_testspy::create_for({})), "Operation 'have_successors' not allowed on empty query");
 	CHECK_THROWS_WITH(query.have_type(command_type::epoch), "Operation 'have_type' not allowed on empty query");
-}
+}