Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement popcount, dot, normalize #27

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Implement popcount, dot, normalize #27

merged 1 commit into from
Dec 21, 2024

Conversation

al42and
Copy link
Contributor

@al42and al42and commented Dec 20, 2024

No description provided.

PeterTh
PeterTh approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@PeterTh PeterTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

fknorr
fknorr approved these changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@fknorr fknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, theres std::popcount! C++20 continues to amaze me.

Thanks!

@fknorr fknorr merged commit ce39577 into celerity:master Dec 21, 2024
8 checks passed
@al42and al42and deleted the popcount-dot-normalize branch December 21, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fknorr fknorr fknorr approved these changes

@PeterTh PeterTh PeterTh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@al42and @PeterTh @fknorr