Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement handler::update_host #18

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Properly implement handler::update_host #18

merged 2 commits into from
Dec 18, 2024

Conversation

fknorr
Copy link
Collaborator

@fknorr fknorr commented Dec 17, 2024

The function was not callable so far, it simply referenced an unimplemented function on accessor of the same name.

Calling buffer_state::write_back requires the state to be available inside accessor, which is why I refactored buffer to internally expose its state rather than pointers and ranges individually. This in turn needs type erasure on Allocator, which I quickly added as well.

Refactor buffer_state to type-erase the allocator and allow embedding
pointers to that state into accessors.
@fknorr fknorr merged commit f661744 into master Dec 18, 2024
16 checks passed
@fknorr fknorr deleted the update-host branch December 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants