Sign in with a passkey through form autofill #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @truongnmt! Sorry for the delay in responding 😕
It's currently returning an error for me, but I like where this is going!
| @@ -31,6 +36,37 @@ function callback(url, body) { | |||
| }); | |||
| } | |||
|
|
|||
| function getCredentialOptions() { | |||
| return _fetch("/session/options").then(function(response) { | |||
There was a problem hiding this comment.
I'm getting a 404 error because we are trying to fetch /session/options which does not exist. It seems that the idea behind this endpoint was to get a challenge from the server right? So that might mean that we will need some kind of Conditional UI endpoint that sets a challenge and return PublicKeyCredentialRequestOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Sign in with a passkey through form autofill. Make the transition from password to passkey-based authentication easier.
Ref:
What