Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miette integration for all errors in Core, Validator, and cedar-policy #477

Merged
merged 14 commits into from
Dec 8, 2023
Merged

miette integration for all errors in Core, Validator, and cedar-policy #477

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f9780e3
miette in core, validator, and public errors
cdisselkoen Dec 6, 2023
82b5f55
reduce usage of std::error::Error
cdisselkoen Dec 6, 2023
c6b621b
tweaks
cdisselkoen Dec 6, 2023
0a1a9de
tests passing
cdisselkoen Dec 7, 2023
e9f5963
more helps
cdisselkoen Dec 8, 2023
2446bd6
CLI improvements, and cargo fmt
cdisselkoen Dec 8, 2023
602b8b5
tweak
cdisselkoen Dec 8, 2023
4df6dab
tweak
cdisselkoen Dec 8, 2023
260e0d1
more
cdisselkoen Dec 8, 2023
1615734
fix tests
cdisselkoen Dec 8, 2023
1f08102
fix corpus tests
cdisselkoen Dec 8, 2023
470ff7d
fixup UnescapeError per comments
cdisselkoen Dec 8, 2023
310c5c1
fixup for UndeclaredCommonTypes message per comments
cdisselkoen Dec 8, 2023
24e7ea5
Apply suggestions from code review
cdisselkoen Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions cedar-integration-tests/corpus_tests/9deac7d6cae0d5e05635469c985c01f9a22e0d1b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: record does not have the attribute `f`. Available attributes: [\"\"]"
"while evaluating policy `policy0`: record does not have the attribute `f`"
]
},
{
Expand All @@ -47,7 +47,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: record does not have the attribute `f`. Available attributes: [\"\"]"
"while evaluating policy `policy0`: record does not have the attribute `f`"
]
},
{
Expand All @@ -70,7 +70,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: record does not have the attribute `f`. Available attributes: [\"\"]"
"while evaluating policy `policy0`: record does not have the attribute `f`"
]
},
{
Expand All @@ -93,7 +93,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: record does not have the attribute `f`. Available attributes: [\"\"]"
"while evaluating policy `policy0`: record does not have the attribute `f`"
]
},
{
Expand All @@ -116,7 +116,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: record does not have the attribute `f`. Available attributes: [\"\"]"
"while evaluating policy `policy0`: record does not have the attribute `f`"
]
},
{
Expand All @@ -139,7 +139,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: record does not have the attribute `f`. Available attributes: [\"\"]"
"while evaluating policy `policy0`: record does not have the attribute `f`"
]
},
{
Expand All @@ -162,7 +162,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: record does not have the attribute `f`. Available attributes: [\"\"]"
"while evaluating policy `policy0`: record does not have the attribute `f`"
]
},
{
Expand All @@ -185,7 +185,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: record does not have the attribute `f`. Available attributes: [\"\"]"
"while evaluating policy `policy0`: record does not have the attribute `f`"
]
}
]
Expand Down
16 changes: 8 additions & 8 deletions cedar-integration-tests/corpus_tests/a7848e613881d5c8ef76a9b4d2daaf5391f604ca.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected ipaddr, got string. Maybe you forgot to apply the `ip` constructor?"
"while evaluating policy `policy0`: type error: expected ipaddr, got string"
]
},
{
Expand All @@ -43,7 +43,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected ipaddr, got string. Maybe you forgot to apply the `ip` constructor?"
"while evaluating policy `policy0`: type error: expected ipaddr, got string"
]
},
{
Expand All @@ -64,7 +64,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected ipaddr, got string. Maybe you forgot to apply the `ip` constructor?"
"while evaluating policy `policy0`: type error: expected ipaddr, got string"
]
},
{
Expand All @@ -85,7 +85,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected ipaddr, got string. Maybe you forgot to apply the `ip` constructor?"
"while evaluating policy `policy0`: type error: expected ipaddr, got string"
]
},
{
Expand All @@ -106,7 +106,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected ipaddr, got string. Maybe you forgot to apply the `ip` constructor?"
"while evaluating policy `policy0`: type error: expected ipaddr, got string"
]
},
{
Expand All @@ -127,7 +127,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected ipaddr, got string. Maybe you forgot to apply the `ip` constructor?"
"while evaluating policy `policy0`: type error: expected ipaddr, got string"
]
},
{
Expand All @@ -148,7 +148,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected ipaddr, got string. Maybe you forgot to apply the `ip` constructor?"
"while evaluating policy `policy0`: type error: expected ipaddr, got string"
]
},
{
Expand All @@ -169,7 +169,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected ipaddr, got string. Maybe you forgot to apply the `ip` constructor?"
"while evaluating policy `policy0`: type error: expected ipaddr, got string"
]
}
]
Expand Down
16 changes: 8 additions & 8 deletions cedar-integration-tests/corpus_tests/ed50cb715d57475bc9dacda0ba0dd77c589832e8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected decimal, got string. Maybe you forgot to apply the `decimal` constructor?"
"while evaluating policy `policy0`: type error: expected decimal, got string"
]
},
{
Expand All @@ -43,7 +43,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected decimal, got string. Maybe you forgot to apply the `decimal` constructor?"
"while evaluating policy `policy0`: type error: expected decimal, got string"
]
},
{
Expand All @@ -64,7 +64,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected decimal, got string. Maybe you forgot to apply the `decimal` constructor?"
"while evaluating policy `policy0`: type error: expected decimal, got string"
]
},
{
Expand All @@ -85,7 +85,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected decimal, got string. Maybe you forgot to apply the `decimal` constructor?"
"while evaluating policy `policy0`: type error: expected decimal, got string"
]
},
{
Expand All @@ -106,7 +106,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected decimal, got string. Maybe you forgot to apply the `decimal` constructor?"
"while evaluating policy `policy0`: type error: expected decimal, got string"
]
},
{
Expand All @@ -127,7 +127,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected decimal, got string. Maybe you forgot to apply the `decimal` constructor?"
"while evaluating policy `policy0`: type error: expected decimal, got string"
]
},
{
Expand All @@ -148,7 +148,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected decimal, got string. Maybe you forgot to apply the `decimal` constructor?"
"while evaluating policy `policy0`: type error: expected decimal, got string"
]
},
{
Expand All @@ -169,7 +169,7 @@
"decision": "Deny",
"reasons": [],
"errors": [
"while evaluating policy `policy0`: type error: expected decimal, got string. Maybe you forgot to apply the `decimal` constructor?"
"while evaluating policy `policy0`: type error: expected decimal, got string"
]
}
]
Expand Down
39 changes: 0 additions & 39 deletions cedar-policy-cli/src/err.rs
View file
Open in desktop

This file was deleted.

Loading
Loading