Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further tweak to CST->EST converison #469

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

john-h-kastner-aws
Copy link
Contributor

Description of changes

Another change to make adding source information to ToASTError nicer. Abstract the pattern node.node.ok_or(ToASTError::MissingNodeData) into one utility function so that when the ToASTError needs a source source location I only have to add it in place instead of everywhere the pattern appears.

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar Dafny model or DRT infrastructure.

Disclaimer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@john-h-kastner-aws john-h-kastner-aws merged commit 3cd8476 into main Dec 7, 2023
6 of 7 checks passed
@john-h-kastner-aws john-h-kastner-aws deleted the refactor/jkastner/est_tweaks branch December 7, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants