Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ergonomics somewhat for the ParseErrors type #445

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

cdisselkoen
Copy link
Contributor

Description of changes

For .push(), .extend(), and .collect(), you no longer need to convert your error to ParseError yourself; those methods will take anything that is Into<ParseError>. This saves a surprising amount of space at a surprising number of callsites.

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar Dafny model or DRT infrastructure.

Disclaimer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cdisselkoen cdisselkoen merged commit 48a9812 into main Nov 17, 2023
6 of 7 checks passed
@cdisselkoen cdisselkoen deleted the refactor/cdisselkoen/parse-errors-ergonomics branch November 17, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants