Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protobuf commands from CLI #1431

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Conversation

john-h-kastner-aws
Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws commented Jan 17, 2025

After this was added to the CLI we added public APIs to access protobuf from cedar-policy which I think is a better mechanism.

Removing this does lose some functionality for generating protobuf specifically for our DRT targets, but I think that this functionality would be better off living in a DRT specific CLI rather than that primary Cedar CLI

Description of changes

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
  • A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
  • A bug fix or other functionality change requiring a patch to cedar-policy.
  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
  • Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
  • I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-docs. PRs should be targeted at a staging-X.Y branch, not main.)
  • I'm not sure how my change impacts the documentation. (Post your PR anyways, and we'll discuss in the comments.)

After this was added to the CLI we added public APIs to access protobuf
from `cedar-policy` which I think is a better mechanism.

Removing this does lose some functionality for generating protobuf
specifically for our DRT targets, but I think that this functionality
would be better off living in a DRT specific CLI rather than that
primary Cedar CLI

Signed-off-by: John Kastner <[email protected]>
@john-h-kastner-aws john-h-kastner-aws force-pushed the remove-cli-proto-commands branch from 383da2a to 334e8df Compare January 17, 2025 19:06
Signed-off-by: John Kastner <[email protected]>
Signed-off-by: John Kastner <[email protected]>
@john-h-kastner-aws john-h-kastner-aws linked an issue Jan 17, 2025 that may be closed by this pull request
2 tasks
@john-h-kastner-aws john-h-kastner-aws merged commit cfb0cb7 into main Jan 17, 2025
19 checks passed
@shaobo-he-aws shaobo-he-aws deleted the remove-cli-proto-commands branch January 17, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid duplicating protobuf schema in CLI
3 participants