Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new method on core Expr #1428

Merged
merged 2 commits into from
Jan 16, 2025
Merged

new method on core Expr #1428

merged 2 commits into from
Jan 16, 2025

Conversation

cdisselkoen
Copy link
Contributor

Description of changes

We have into_expr_kind() and into_data(), but no way for other Core consumers to consume the Expr and get back both the kind and the data.

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.

Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
@cdisselkoen
Copy link
Contributor Author

CI failure should be resolved by #1427

@cdisselkoen cdisselkoen merged commit a4ff416 into main Jan 16, 2025
18 of 19 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/expr-method branch January 16, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants