-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema options for partially-authorize
command
#1416
Merged
adpaco-aws
merged 11 commits into
cedar-policy:main
from
adpaco-aws:partial-auth-schema-args
Jan 9, 2025
Merged
Schema options for partially-authorize
command
#1416
adpaco-aws
merged 11 commits into
cedar-policy:main
from
adpaco-aws:partial-auth-schema-args
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Palacios <[email protected]>
Unclear how to handle validation errors here. Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
adpaco-aws
requested review from
cdisselkoen,
shaobo-he-aws and
john-h-kastner-aws
January 8, 2025 22:04
john-h-kastner-aws
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
cdisselkoen
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
cdisselkoen
approved these changes
Jan 9, 2025
Co-authored-by: Craig Disselkoen <[email protected]> Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
adpaco-aws
force-pushed
the
partial-auth-schema-args
branch
from
January 9, 2025 17:24
0db8cfe
to
30532ff
Compare
shaobo-he-aws
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds the schema options
schema
andschema-format
to thepartially-authorize
command, which were not included in #1082. Basically, we add the schema options toPartiallyAuthorizeArgs
, extendget_request
with an optional schmea argument and rely on the existing builder from #393 to build requests with partial evaluation.Issue #, if available
Resolves #1332
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., changes to the signature of an existing API).cedar-policy
(e.g., addition of a new API).cedar-policy
.cedar-policy-core
,cedar-validator
, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)cedar-spec
. (Post your PR anyways, and we'll discuss in the comments.)I confirm that
docs.cedarpolicy.com
(choose one, and delete the other options):cedar-docs
. PRs should be targeted at astaging-X.Y
branch, notmain
.)