Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: env var cleanup across repos #35

Merged
merged 2 commits into from
Sep 25, 2024
Merged

breaking: env var cleanup across repos #35

merged 2 commits into from
Sep 25, 2024

Conversation

nravic
Copy link
Contributor

@nravic nravic commented Sep 24, 2024

Describe your changes

BREAKING: cedana-api-server is changed to cedana-url & cedana-api-token is changed to cedana-auth-token. Update your values and env vars accordingly.

Caveats (if any)

Issue Ticket ID

Checklist before requesting a review

  • Code compiles correctly.
  • Self-review to ensure, the PR only introduces the changes it's intended to? E.g. No extraneous formatting changes.
  • Created tests which fail without the change (if possible).
  • Rest of the tests are passing.
  • Is this a breaking change? If yes, please describe areas affected and request reviews from developer stakeholders.
  • Extended the README / documentation, if changes have resulted in it being out of date?

@nravic nravic changed the title Env var cleanup across repos breaking: env var cleanup across repos Sep 24, 2024
@bsmithai bsmithai merged commit 21e5b6d into main Sep 25, 2024
1 check failed
@bsmithai bsmithai deleted the feat/env-var-cleanup branch September 25, 2024 23:32
rahulk789 pushed a commit that referenced this pull request Oct 1, 2024
@nravic @rahulk789
breaking: env var cleanup across repos (#35)
4f9e1e5 
* fix: refactoring secrets a little

* fix: more env var changes
nravic added a commit that referenced this pull request Oct 2, 2024
@rahulk789 @nravic
feat: Redis deployment and svc with README (#34)
7fea8b4 
* feat: Redis deployment and svc with README

* feat: added README

* breaking: env var cleanup across repos (#35)

* fix: refactoring secrets a little

* fix: more env var changes

* fix: cedana checkpoint curl

---------

Co-authored-by: Niranjan Ravichandra <[email protected]>
Co-authored-by: Niranjan Ravichandra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nravic @bsmithai