-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduler time zone addons + a11y improvements for form elements. #1949
base: main
Are you sure you want to change the base?
Conversation
🧪 Review environmenthttps://ap75a6c642ylyzc7jt72smwyg40ffqnn.lambda-url.ca-central-1.on.aws/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -32,7 +32,7 @@ export const Time = ({ name }) => { | |||
}); | |||
}} | |||
id={name} | |||
aria-label={name} | |||
aria-describedby={`${name}-hint`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this id get set? I see a similar looking id over here but that one is static 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing with voice over, it correctly read out the hint, so this works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few lines below and above where you found! I figured they were close enough to just append name
with hint
Summary | Résumé
This PR adds precisions about time-zone when scheduling messages. It also improves general a11y of the scheduler by
Test instructions | Instructions pour tester la modification
Todo: