Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/templates filter macro #1877
Feat/templates filter macro #1877
Changes from all commits
2dfa554
ac842c2
8d64f00
3dfe3d2
8a1967f
907f0a2
6f9af0f
341945b
00c9bcd
8c50e90
bdd2af8
e5143ea
0774eff
e1bf1dd
fa4517b
2c436bf
5e1824f
7cf45c6
1981e0f
ac41be5
678cb82
e873ce6
6ce839c
07a2a8a
e418d97
78c6308
df53dcd
cb05cca
625e3d7
c24e6f3
5642083
dcf33d7
7ef072e
a0ad29c
50109c2
5d8e060
1826fdd
4a68e6a
f52a981
5fc84c3
a939061
f0518f9
296e2e8
5e075a6
247204f
cf03821
5044e2c
f026c17
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lists are passed into the template-filter macro to use as the filters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just to know which template category field to show, based on the current app language. There may be a cleaner way to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds the template_category into the TemplateList that is used when showing the list of available tempaltes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this docstring so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove pl gutter here to keep things aligned.