Support for Card and Keyword iteration on header #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chrsoo, I added a test retrieving calling cards iter. I realize Keyword may not be very friendly. Would it be better to have a proper Keyword type being just a [u8; 8] that has a method to get its owned String trimmed value (the method you made on Card) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to the question raised in Issue #9 and provides support for the following:
Note 1: I did not create test cases for the Card and Keyword iterators due to the issue related to
git-lfsreported in issue #10. On the other hand, this change is trivial and was tested locally from another project.Note 2: Retrieving the Keyword as a trimmed and owned String can be considered syntactic sugar, but it scratches the itch of having to work with byte arrays for Strings...