Fixes the grid options #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the parameters gridColor, gridOpacity, and gridOptions.showLabels are no longer ignored add gridOptions to the API description edit default values for the grid to fit the aladin style a bit better
bmatthieu3
reviewed
Mar 8, 2024
ManonMarchand
force-pushed
the
fix-grid-options
branch
from
32b567b to
ce97449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the PR does
Aladin.DEFAULT_OPTIONSinstead of the user options)showLabels,thicknessandlabelSizeto the usersAladinOptionsAPI (they could only be changed in the GUI, but not at startup)