-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nunjucks w/ npm auto-update #1689
Conversation
The CI failure indicates that I need to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty
Yeah, it used to be a thing, but when the bot was rewritten it looks like support got dropped for it. It probably should be a thing again, but hey, that's not my call. |
@MattIPv4 Hmm I'm not seeing any new versions or the latest version showing up with assets on https://cdnjs.com/... I'm seeing assets for LiquidJS, my other PR merged the other day, but not here. Am I missing something or did I configure it wrong? |
It looks like the versions listed there were all processed prior to your PR being merged. Once a new version of nunjucks is released, the new config should be used for it to be processed. |
Let me see, there used to be an endpoint we could hit internally to re-process a version 🔍 |
Re-processed 3.2.4, looks like it picked up all the files expected: https://github.com/cdnjs/logs/tree/prod/packages/n/nunjucks/3.2.4 / https://api.cdnjs.com/libraries/nunjucks/3.2.4 |
Yay thank you! Much appreciated. |
Nunjucks stopped bundling files in the Git repository itself and only publishes them as part of the NPM package.
Refs #302.