Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nunjucks w/ npm auto-update #1689

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Update nunjucks w/ npm auto-update #1689

merged 2 commits into from
Nov 6, 2023

Conversation

uncenter
Copy link
Contributor

Nunjucks stopped bundling files in the Git repository itself and only publishes them as part of the NPM package.

Refs #302.

@uncenter
Copy link
Contributor Author

The CI failure indicates that I need to remove ignoreVersions - is this not used anymore or somthing?

@MattIPv4 MattIPv4 changed the title Update Nunjucks w/ npm auto-update Update nunjucks w/ npm auto-update Nov 6, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty

@MattIPv4 MattIPv4 merged commit 7e58ec8 into cdnjs:master Nov 6, 2023
1 check passed
@MattIPv4
Copy link
Member

MattIPv4 commented Nov 6, 2023

The CI failure indicates that I need to remove ignoreVersions - is this not used anymore or somthing?

Yeah, it used to be a thing, but when the bot was rewritten it looks like support got dropped for it. It probably should be a thing again, but hey, that's not my call.

@uncenter
Copy link
Contributor Author

uncenter commented Nov 7, 2023

@MattIPv4 Hmm I'm not seeing any new versions or the latest version showing up with assets on https://cdnjs.com/...
https://cdnjs.com/libraries/nunjucks/3.2.4

I'm seeing assets for LiquidJS, my other PR merged the other day, but not here. Am I missing something or did I configure it wrong?

@uncenter
Copy link
Contributor Author

uncenter commented Nov 7, 2023

I specified that the basePath would be browser and it should match all files with this glob: nunjucks* - seems all good to me?

image

@MattIPv4
Copy link
Member

MattIPv4 commented Nov 7, 2023

It looks like the versions listed there were all processed prior to your PR being merged. Once a new version of nunjucks is released, the new config should be used for it to be processed.

@uncenter
Copy link
Contributor Author

uncenter commented Nov 7, 2023

Ah okay... no way to trigger it manually? Nunjucks doesn't get new releases often.

image

@MattIPv4
Copy link
Member

MattIPv4 commented Nov 7, 2023

Let me see, there used to be an endpoint we could hit internally to re-process a version 🔍

@MattIPv4
Copy link
Member

MattIPv4 commented Nov 8, 2023

Re-processed 3.2.4, looks like it picked up all the files expected: https://github.com/cdnjs/logs/tree/prod/packages/n/nunjucks/3.2.4 / https://api.cdnjs.com/libraries/nunjucks/3.2.4

@uncenter
Copy link
Contributor Author

uncenter commented Nov 8, 2023

Yay thank you! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants