CDAP-21091: Increasing timeout for task workers to recover when app fabric restarts #15855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+62
to
+64
| private static final int NUMBER_OF_RETRIES = 20; | ||
| private static final int MIN_WAIT_TIME_MILLISECOND = 2000; | ||
| private static final int MAX_WAIT_TIME_MILLISECOND = 60000; |
There was a problem hiding this comment.
can we please move these to cconf?
There was a problem hiding this comment.
Let's move only the NUMBER_OF_RETRIES to cconf.
That's the value we would need to modify mainly to configure the retry behavior.
There was a problem hiding this comment.
I think we should keep min / max wait time the same and make NUMBER_OF_RETRIES configurable in cconf.
If later we figure out that the number of retries are insufficient, we won't have to make data plane changes for it.
There was a problem hiding this comment.
PR description should be of the form: data-integrations/google-cloud#1473 (comment)
|
anshumanks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing timeout for task workers to recover when app fabric restarts
Jira: CDAP-21091
Description
This change lets the task workers restart gracefully when app fabric pod is restarted.
Code change
ComputeEngineCredentials.java