[CDAP-21096] Keep TaskWorkerServiceLauncher, SystemWorkerServiceLauncher, CoreSchedulerService, Schedule HTTP handlers in Appfabric Processor #15844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsethi09
force-pushed
the
fix/CDAP-21096_task_workers
branch
6 times, most recently
from
e806137 to
562c886
Compare
vsethi09
changed the title
| } | ||
|
|
||
| /** | ||
| * Returns status of a type specified by the type{flows,workflows,mapreduce,spark,services,schedules}. |
There was a problem hiding this comment.
nit: returns status of schedule.
similar comment for all such comments. Please also update them in ProgramLifecycleHttpHandler
cdap-app-fabric/src/main/java/io/cdap/cdap/gateway/handlers/ProgramScheduleHttpHandler.java
Show resolved
Hide resolved
vsethi09
force-pushed
the
fix/CDAP-21096_task_workers
branch
2 times, most recently
from
7b5a0cd to
4e6f294
Compare
…her, CoreSchedulerService, Schedule HTTP handlers in Appfabric Processor Move scheduler services and http handler to appfabric processor Add max retry count in Provisioning service
vsethi09
force-pushed
the
fix/CDAP-21096_task_workers
branch
from
4e6f294 to
bd35cab
Compare
itsankit-google
approved these changes
Feb 5, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDAP-21096 Keep TaskWorkerServiceLauncher, SystemWorkerServiceLauncher, CoreSchedulerService, Schedule HTTP handlers in Appfabric Processor (singleton service)
Change Description
TaskWorkerServiceLauncherandSystemWorkerServiceLauncherfromAppFabricServiceMain.CoreSchedulerServiceto Appfabric server.ScheduleNotificationSubscriberServicetoCoreSchedulerServiceas it used to be before [CDAP-21096] Split Appfabric into stateless service and stateful processor #15773.ProgramLifecycleHttpHandlerto a new handlerProgramScheduleHttpHandler, which runs only in Appfabric Processor.Verification