[CDAP-21079] Refactor SPI/TMS for default context before spanner extension implementation #15731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidhdirenge
changed the title
chtyim
reviewed
Nov 13, 2024
cdap-messaging-spi/src/main/java/io/cdap/cdap/messaging/spi/MessagingContext.java
Outdated
Show resolved
Hide resolved
chtyim
reviewed
Nov 13, 2024
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/messaging/DelegatingMessagingService.java
Outdated
Show resolved
Hide resolved
chtyim
reviewed
Nov 13, 2024
| @@ -130,6 +135,11 @@ private MessagingService getDelegate() { | |||
| "Unsupported messaging service implementation " + getName()); | |||
| } | |||
| LOG.info("Messaging service {} is loaded", messagingService.getName()); | |||
| try { | |||
| messagingService.initialize(new DefaultMessagingContext(this.cConf)); | |||
There was a problem hiding this comment.
Why move here instead of doing it in the regular initialize method?
There was a problem hiding this comment.
Messaging currently doesn't have initialize().
We need this to create spanner database clients. Extension is loaded at this particular place and the current object's delegate is set to the messagingService. So thought this would be an appropriate place for initialize().
chtyim
reviewed
Nov 13, 2024
...pp-fabric/src/main/java/io/cdap/cdap/internal/messaging/MessagingServiceExtensionLoader.java
Outdated
Show resolved
Hide resolved
sidhdirenge
added
build
masoud-io
approved these changes
Nov 19, 2024
cdap-tms/src/main/java/io/cdap/cdap/messaging/client/DelegatingMessagingService.java
Show resolved
Hide resolved
…nsion implementation
sidhdirenge
force-pushed
the
sidhdirenge-refactor-messaging-spi
branch
from
4901eea to
3e37e7d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by deploying docker image to GCP project.
All pods up and running.