Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-21010] Implement count() method for SpannerStructuredTable #15697

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

sidhdirenge
Copy link
Contributor

@sidhdirenge sidhdirenge commented Sep 11, 2024

This method was not implemented as part of : #15612

Test evidences

Pipeline run:
image

Before change:
image

After:
image

@sidhdirenge sidhdirenge marked this pull request as ready for review September 12, 2024 13:33
@sidhdirenge sidhdirenge self-assigned this Sep 12, 2024
@itsankit-google itsankit-google added the build Triggers github actions build label Sep 12, 2024
@sidhdirenge sidhdirenge changed the title Implement count() method for SpannerStructuredTable [CDAP-21010] Implement count() method for SpannerStructuredTable Sep 12, 2024
@sidhdirenge sidhdirenge force-pushed the sidhdirenge-fix-spanner-count-impl branch from 564cdf6 to 6938fd3 Compare September 12, 2024 14:25
@itsankit-google itsankit-google added build Triggers github actions build and removed build Triggers github actions build labels Sep 12, 2024
Copy link

@sidhdirenge sidhdirenge merged commit 0600222 into develop Sep 16, 2024
14 checks passed
@sidhdirenge sidhdirenge deleted the sidhdirenge-fix-spanner-count-impl branch September 16, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Triggers github actions build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants