Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added explicit classloader to the BigQuery SQL Engine Adapter child threads #14110

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Added explicit classloader to the BigQuery SQL Engine Adapter child threads #14110

merged 1 commit into from
Mar 23, 2022

Conversation

fernst
Copy link
Member

@fernst fernst commented Mar 22, 2022

No description provided.

@fernst fernst requested review from tivv and chtyim March 22, 2022 18:24
@gitpod-io
Copy link

gitpod-io bot commented Mar 22, 2022

@fernst fernst requested a review from albertshau March 22, 2022 19:09
@fernst fernst force-pushed the sql-engine-adapter-classloader branch 2 times, most recently from 557f31f to 20abc1c Compare March 22, 2022 19:34
@fernst fernst force-pushed the sql-engine-adapter-classloader branch from 20abc1c to 43dea6e Compare March 22, 2022 19:50
tivv
tivv reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@tivv tivv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending confirmation it actually fixes the issue.

@fernst fernst added the build Triggers github actions build label Mar 22, 2022
@fernst fernst merged commit 7a552d8 into develop Mar 23, 2022
@fernst fernst deleted the sql-engine-adapter-classloader branch March 23, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tivv tivv tivv approved these changes

@chtyim chtyim Awaiting requested review from chtyim

@albertshau albertshau Awaiting requested review from albertshau

Assignees
No one assigned
Labels
bq-pushdown build Triggers github actions build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernst @tivv