-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New noise support in tnsim #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## new-noise-aware-sims #83 +/- ##
======================================================
+ Coverage 75.2% 76.0% +0.7%
======================================================
Files 118 120 +2
Lines 6285 6486 +201
Branches 281 281
======================================================
+ Hits 4727 4930 +203
+ Misses 1558 1556 -2
*This pull request uses carry forward flags. Click here to find out more.
|
## Description This pull request suggests to introduce new noise model for qudits. It consists of two ideas: "Mathematical Noise" & "Physical Noise". There are some limitations as follows now. * The data structure of Noise is defined. * It is supported by only `tnsim`, not `misim`. * To clear the tests, some code changes are made in `misim`. * However, `misim` cannot simulate neither correctly. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. Co-authored-by: Yusuke Kimura <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
This pull request suggests to introduce new noise model for qudits.
It consists of two ideas: "Mathematical Noise" & "Physical Noise".
There are some limitations as follows now.
tnsim
, notmisim
.misim
.misim
cannot simulate neither correctly.Checklist: