Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New noise support in tnsim #83

Merged
merged 28 commits into from
Nov 25, 2024
Merged

Conversation

kkyusuke
Copy link
Contributor

@kkyusuke kkyusuke commented Oct 30, 2024

Description

This pull request suggests to introduce new noise model for qudits.
It consists of two ideas: "Mathematical Noise" & "Physical Noise".
There are some limitations as follows now.

  • The data structure of Noise is defined.
  • It is supported by only tnsim, not misim.
    • To clear the tests, some code changes are made in misim.
    • However, misim cannot simulate neither correctly.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@kkyusuke kkyusuke marked this pull request as draft November 6, 2024 18:04
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 76.0%. Comparing base (fc62c6b) to head (a7af12c).
Report is 2 commits behind head on new-noise-aware-sims.

Files with missing lines Patch % Lines
src/mqt/qudits/quantum_circuit/gates/noise_x.py 89.3% 5 Missing ⚠️
src/mqt/qudits/quantum_circuit/gates/noise_y.py 89.3% 5 Missing ⚠️
...ts/simulation/noise_tools/noisy_circuit_factory.py 94.6% 4 Missing ⚠️
src/mqt/qudits/simulation/noise_tools/noise.py 98.1% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           new-noise-aware-sims     #83     +/-   ##
======================================================
+ Coverage                  75.2%   76.0%   +0.7%     
======================================================
  Files                       118     120      +2     
  Lines                      6285    6486    +201     
  Branches                    281     281             
======================================================
+ Hits                       4727    4930    +203     
+ Misses                     1558    1556      -2     
Flag Coverage Δ *Carryforward flag
cpp 61.9% <ø> (ø) Carriedforward from f756958
python 80.7% <93.7%> (+0.8%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/qudits/quantum_circuit/circuit.py 89.7% <100.0%> (+0.3%) ⬆️
src/mqt/qudits/quantum_circuit/gates/__init__.py 100.0% <100.0%> (ø)
...imulation/backends/fake_backends/fake_traps2six.py 97.8% <100.0%> (+<0.1%) ⬆️
...ulation/backends/fake_backends/fake_traps2three.py 97.8% <100.0%> (+<0.1%) ⬆️
...imulation/backends/fake_backends/fake_traps3six.py 98.0% <100.0%> (+<0.1%) ⬆️
src/mqt/qudits/simulation/noise_tools/__init__.py 100.0% <100.0%> (ø)
src/mqt/qudits/simulation/noise_tools/noise.py 98.6% <98.1%> (+16.8%) ⬆️
...ts/simulation/noise_tools/noisy_circuit_factory.py 95.5% <94.6%> (+7.1%) ⬆️
src/mqt/qudits/quantum_circuit/gates/noise_x.py 89.3% <89.3%> (ø)
src/mqt/qudits/quantum_circuit/gates/noise_y.py 89.3% <89.3%> (ø)

... and 5 files with indirect coverage changes

@kkyusuke kkyusuke marked this pull request as ready for review November 7, 2024 20:30
@KevinMTO KevinMTO merged commit a968d89 into cda-tum:new-noise-aware-sims Nov 25, 2024
18 checks passed
KevinMTO added a commit that referenced this pull request Nov 26, 2024
## Description

This pull request suggests to introduce new noise model for qudits. It
consists of two ideas: "Mathematical Noise" & "Physical Noise". There
are some limitations as follows now.

* The data structure of Noise is defined.
* It is supported by only `tnsim`, not `misim`.
  * To clear the tests, some code changes are made in `misim`.
  * However, `misim` cannot simulate neither correctly.

## Checklist:

<!---
This checklist serves as a reminder of a couple of things that ensure
your pull request will be merged swiftly.
-->

- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [x] I have made sure that all CI jobs on GitHub pass.
- [x] The pull request introduces no new warnings and follows the
project's style guidelines.

Co-authored-by: Yusuke Kimura <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants