Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Two Benchmarking Quantum Circuits: quarkcardinality and quarkcopula #463

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fkiwit
Copy link

@fkiwit fkiwit commented Jan 13, 2025

This pull request adds two benchmarking quantum circuits from the generative modeling application of the QUARK framework:

  • quarkcardinality.py
  • quarkcopula.py

Both circuits are part of the QUARK framework: QUARK GitHub Repository

fkiwit and others added 3 commits January 8, 2025 19:06
This commit adds two benchmark circuits, "quark_cardinality_circuit.py" and "quark_copula_circuit.py"
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.8%. Comparing base (c68f189) to head (c11f6f9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #463   +/-   ##
=====================================
  Coverage   92.8%   92.8%           
=====================================
  Files         43      43           
  Lines       1969    1969           
=====================================
  Hits        1828    1828           
  Misses       141     141           
Flag Coverage Δ
python 92.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nquetschlich nquetschlich self-assigned this Jan 13, 2025
@nquetschlich nquetschlich added enhancement New feature or request feature New feature or request labels Jan 13, 2025
@nquetschlich
Copy link
Collaborator

Thanks a lot for contributing your benchmarks to MQT Bench @fkiwit. As discussed, we will integrate them with the update of MQT Bench that allows for OpenQASM 3 export. I just leave a few todos we have to complete when integrating the benchmarks into the updated MQT Bench version (this is more a reminder for me rather than it is meant that you need to do these things):

  • replace random parameter values with actual parameters (and maybe an option to assign random ones)
  • add these benchmarks to the config file (if still present)
  • add documentation for both circuits for the website and read the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants