✨ Added timeout for QuickSim
#654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Outdated
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
bindings/mnt/pyfiction/include/pyfiction/algorithms/simulation/sidb/sidb_simulation_result.hpp
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
==========================================
- Coverage 98.41% 98.40% -0.01%
==========================================
Files 252 252
Lines 40856 40880 +24
Branches 1863 1865 +2
==========================================
+ Hits 40207 40228 +21
- Misses 649 652 +3
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: GitHub Actions <[email protected]>
marcelwa
reviewed
Feb 7, 2025
| // measure run time (artificial scope) | ||
| // main loop |
There was a problem hiding this comment.
This comment (// main loop) seems to be misplaced
Comment on lines
+47
to
+50
| /** | ||
| * Timeout limit (in ms). | ||
| */ | ||
| uint64_t timeout = std::numeric_limits<uint64_t>::max(); |
There was a problem hiding this comment.
I believe, we usually specify our timeouts in seconds. Please check exact and gold to be sure.
Comment on lines
+88
to
+92
| if (ps.timeout == 0) | ||
| { | ||
| st.additional_simulation_parameters.emplace("timeout_reached", true); | ||
| return st; | ||
| } |
There was a problem hiding this comment.
Is it really a simulation parameter that the timeout has been reached? In exact, we throw an exception in the _impl class that we then catch in the calling function exact and return an std::nullopt. I'm not 100% sure how gold handles this. You might wanna check.
| mockturtle::stopwatch<>::duration time_counter{}; | ||
|
|
||
| // Track the start time for timeout | ||
| auto start_time = std::chrono::high_resolution_clock::now(); |
Comment on lines
+238
to
+241
| if (timeout_limit_reached) | ||
| { | ||
| st.additional_simulation_parameters.emplace("timeout_reached", true); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the option to set a timeout in QuickSim to avoid endless simulations.
Checklist: