🩹 Non-critical fixes w.r.t. the ClusterComplete merge (#390)
#652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlambooy
changed the title
ClusterComplete mergeClusterComplete merge (#390)
Drewniok
reviewed
Jan 30, 2025
experiments/equivalence_checking_exact_simulation/equivalence_checking_exact_simulation.cpp
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
experiments/equivalence_checking_exact_simulation/equivalence_checking_exact_simulation.cpp
Outdated
Show resolved
Hide resolved
experiments/equivalence_checking_exact_simulation/equivalence_checking_exact_simulation.cpp
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 252 252
Lines 40856 40856
Branches 1863 1864 +1
=======================================
+ Hits 40205 40206 +1
+ Misses 651 650 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Drewniok
reviewed
Jan 31, 2025
experiments/equivalence_checking_exact_simulation/equivalence_checking_exact_simulation.cpp
Show resolved
Hide resolved
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves two non-critical issues that were discovered shortly after merging #390 .
Checklist: