Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual pi network #543

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Virtual pi network #543

wants to merge 25 commits into from

Conversation

hibenj
Copy link
Collaborator

@hibenj hibenj commented Oct 16, 2024

Description

This PR includes the virtual_pi_network.hpp, virtual_pi_network.cpp(testing) and virtual_pi_network.rst(documentation), as well as the necessary changes in traits.hpp
The virtual PI network enhances all mockturtle network types to store duplicates of their PIs, called virtual PIs.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 90.44586% with 30 lines in your changes missing coverage. Please review.

Project coverage is 98.10%. Comparing base (2e24360) to head (ba87098).

Files with missing lines Patch % Lines
test/networks/virtual_pi_network.cpp 91.83% 16 Missing ⚠️
include/fiction/networks/virtual_pi_network.hpp 88.13% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   98.18%   98.10%   -0.08%     
==========================================
  Files         226      228       +2     
  Lines       31765    32083     +318     
  Branches     1580     1601      +21     
==========================================
+ Hits        31187    31475     +288     
- Misses        578      608      +30     
Files with missing lines Coverage Δ
include/fiction/networks/virtual_pi_network.hpp 88.13% <88.13%> (ø)
test/networks/virtual_pi_network.cpp 91.83% <91.83%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e24360...ba87098. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

test/networks/virtual_pi_network.cpp Outdated Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Outdated Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Outdated Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Outdated Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

test/networks/virtual_pi_network.cpp Outdated Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Outdated Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Outdated Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Outdated Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Outdated Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Outdated Show resolved Hide resolved
test/networks/virtual_pi_network.cpp Show resolved Hide resolved
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants