✨ Post-Layout Optimization #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
+ Coverage 95.12% 95.41% +0.28%
==========================================
Files 95 96 +1
Lines 8965 9422 +457
==========================================
+ Hits 8528 8990 +462
+ Misses 437 432 -5
☔ View full report in Codecov by Sentry. |
simon1hofmann
changed the title
marcelwa
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Please add unit tests in test/algorithms/physical_design/optimization.cpp. We cannot know whether your code performs the intended functionality without unit tests. That also means, that when I make changes, I cannot see whether I broke something. Since I do not understand the code as well as you do, I would have to rely on the test output whenever I make adjustments.
…o post_placement_optimization
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
experiments/post_layout_optimization/post_layout_optimization.cpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
marcelwa
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an optimization algorithm that reduces the layout area of sub-optimal Cartesian 2DDWave-clocked layouts.
This algorithms includes:
This reduces the area of layouts for a set of benchmark functions generated with
orthoandNanoPlaceRby an average of50%and20%, respectively.Checklist: