-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
➖ Remove unit
library due to increasing simulation runtimes.
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [libs/Catch2](https://github.com/catchorg/Catch2) from `6783411` to `1f881ab`. - [Release notes](https://github.com/catchorg/Catch2/releases) - [Commits](catchorg/Catch2@6783411...1f881ab) --- updated-dependencies: - dependency-name: libs/Catch2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [libs/parallel-hashmap](https://github.com/greg7mdp/parallel-hashmap) from `7883cb6` to `d2bed96`. - [Release notes](https://github.com/greg7mdp/parallel-hashmap/releases) - [Commits](greg7mdp/parallel-hashmap@7883cb6...d2bed96) --- updated-dependencies: - dependency-name: libs/parallel-hashmap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
marcelwa
requested changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the effort. I don't see any immediate problems with it. There are just a couple more places where I would like to see unit hints in the docstrings.
include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/energy_distribution.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/energy_distribution.hpp
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #258 +/- ##
==========================================
+ Coverage 94.57% 94.67% +0.10%
==========================================
Files 85 84 -1
Lines 7669 7648 -21
==========================================
- Hits 7253 7241 -12
+ Misses 416 407 -9
|
marcelwa
previously approved these changes
Jul 25, 2023
marcelwa
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverses the use of the
unit
library. This is necessary because the runtimes of the physical simulation algorithms increase when the unit library is used.Checklist: