Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding array support in Type #407

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Adding array support in Type #407

merged 6 commits into from
Nov 9, 2023

Conversation

nshaheed
Copy link
Contributor

@nshaheed nshaheed commented Nov 6, 2023

This is my first-draft attempt at adding array support in Type. Currently there's some inconsistency in behavior. The following code:

[1] @=> int arr_prim[];

<<< Type.of(arr_prim).name() >>>;
<<< Type.of(arr_prim).isArray() >>>;

<<< Type.find("int[]").name() >>>;
<<< Type.find("int[]").isArray() >>>;

Prints out

"@array" :(string)
0 :(int)
"int[]" :(string)
1 :(int)

So, isArray() is working for find, but not of.

Copy link
Member

@gewang gewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array create() from chugin does not fully work, but approving and merging PR in order to work on it further in chuck repo

@gewang gewang merged commit 82b2d4b into ccrma:main Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants