Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for up to Unraid 7.0.1 #5

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

dohnutt
Copy link

@dohnutt dohnutt commented Feb 27, 2025

In keeping with the spirit of the strategy as stated in the README, this PR attempts to fix the issues brought about by Unraid 7 in the least disruptive way possible.

As such, this fixes two main issues I came across:

  1. viewport width issues where #displaybox is setting a min-width on the page.
  2. rather than compressing tables into the viewport, it allows them to display at a larger size, with horizontal scrollbars to navigate them. It uses this method to do so: https://stackoverflow.com/questions/17770257/scrolling-tables-horizontally-without-wrapping-them-in-div

Admittedly, I hadn't used this repo in Unraid 6 — in fact I am a very new Unraid user, having only ever used version 7 — but I hope it falls in line with what you've done in the past. Thanks for getting the ball rolling, I hope this is helpful to you!


Two additional proposals, which could be broken out into other PRs:

  1. I think it would be better to link to remote CSS rather than instruct the user to copy/paste the entire CSS contents into the Theme Engine CSS field. I'm using https://raw.githack.com to proxy the repo's CSS file so it's easy maintenance.

  2. I noticed that tabs and their content are forced to display rather than just continuing to use them as-is. In my limited testing, the tabs worked perfectly fine for mobile but perhaps there was a reason for this. I left this code untouched but may adjust it in my own personal use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant