Add 2023 tax bills #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. Here's the 2023 tax bills to add to your branch. |
|
@erhla There's also the |
dfsnow
requested changes
Jul 23, 2024
Comment on lines
6
to
22
| sum_path <- "data-raw/sample_tax_bills/sample_tax_bills_summary.csv" | ||
|
|
||
|
|
||
| # add pins/year/class after updating detail | ||
| key_cols <- readr::read_csv( | ||
| "data-raw/sample_tax_bills/sample_tax_bills_detail.csv" | ||
| ) %>% | ||
| distinct(year, pin, class) %>% | ||
| mutate(class = as.character(class)) %>% | ||
| filter(year == max(year)) | ||
|
|
||
| readr::read_csv( | ||
| sum_path, | ||
| col_types = cols(pin = "c", tax_code = "c", class = "c") | ||
| ) %>% | ||
| bind_rows(key_cols) %>% | ||
| write_csv(sum_path) |
There was a problem hiding this comment.
issue (blocking): I get the intent but let's not add this programmatically. It's fine if you wanna use it to help jumpstart the manual work on each bill though.
Also, somehow it's mangling the CSV, see below.
There was a problem hiding this comment.
issue (blocking): Looks like some of the 0000 PINs get mangled and converted to scientific notation here. No bueno.
This reverts commit d0e31ea.
Capture manual reviewed fields from tax bills via terminal entry
dfsnow
added a commit
that referenced
this pull request
Aug 6, 2024
* Add updated agency workbooks and code * Add new CPI PDF * Add 2023 equalizers * Bump DB version in DESCRIPTION and DB * Add 2023 tax bills (#41) * add 2023 tax bills * lint * styler? * attempt 2 to style * add rpm tif * update data * Revert "update data" This reverts commit d0e31ea. * fixing tax bill summary / adding input procedure Capture manual reviewed fields from tax bills via terminal entry * Drop extraneous readline code * Swap tabulapdf for deprecated tabulizer dependency * Update TIF agency names output * Add 2023 TIF report data * Fix pct formatting for pct_burden, reduction_pct * Fix TIF records with missing agency number * Update README figures and links * Update sample summary with additional bill * Update test thresholds * Bump package version * Cleanup pkgdown manifest --------- Co-authored-by: Eric Langowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.