Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

265 clean up and document analyses section #313

Open
wants to merge 30 commits into
base: 2025-assessment-year
Choose a base branch
from

Conversation

Damonamajor
Copy link
Contributor

@Damonamajor Damonamajor commented Jan 7, 2025

This does a few main things.

  • It updates the analyses reports to track changes uncovered by the new feature (improving charts, etc.).
  • It adds a README with context for the directory.
  • It moves it to a subfolder with separate processes for categorical and continuous reports. There were too many discrepancies between the two types to have them integrated in one report.
  • It doesn't do anything with the helpers since they are similar, but not identical.
  • Moves some of the bigger function to the Helper.R file.
  • HTML files still aren't allowed to be uploaded, so I can't implement any of the folder structures.

Let me know if there's a better way to tackle it, because it's pretty hefty.
I'm happy to add additional commenting / documentation, but if we want to change structures, I'm hesitant to do it now.

…-avm into 265-clean-up-and-document-analyses-section
Merge branch '2025-assessment-year' of github.com:ccao-data/model-res-avm into 265-clean-up-and-document-analyses-section
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Merge branch '2025-assessment-year' of github.com:ccao-data/model-res-avm into 265-clean-up-and-document-analyses-section
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@Damonamajor Damonamajor linked an issue Jan 7, 2025 that may be closed by this pull request
@Damonamajor Damonamajor marked this pull request as ready for review January 8, 2025 15:34
Merge branch '2025-assessment-year' into 265-clean-up-and-document-analyses-section
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up and document analyses/ section
1 participant